Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83022
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEbg-4aZytKiqG3Y5U-HrBMp2+JuGHu3UTOMLWiiUQn59FtpLw@mail.gmail.com>
References: <CAEbg-4aZytKiqG3Y5U-HrBMp2+JuGHu3UTOMLWiiUQn59FtpLw@mail.gmail.com>
Date: Wed, 18 Feb 2015 10:22:54 +0400
Message-ID: <CA+9eiLvkoTB2xdo4a6AdDnU8fjxOBbog+4FHm-UyBZzWNOQd4Q@mail.gmail.com>
To: Alexander Lisachenko <lisachenko.it@gmail.com>, Nikita Popov <nikic@php.net>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01538610829697050f56d9f5
Subject: Re: [PHP-DEV] [RFC][Discussion] Parser extension API
From: dmitry@zend.com (Dmitry Stogov)

--089e01538610829697050f56d9f5
Content-Type: text/plain; charset=UTF-8

Hi,

On Tue, Feb 17, 2015 at 2:46 PM, Alexander Lisachenko <
lisachenko.it@gmail.com> wrote:

> Hello, internals!
>
> I want to introduce a RFC for providing a userland API for accessing an
> Abstract Syntax Tree of the source code and to provide userland parser
> hooks for source code modification:
> https://wiki.php.net/rfc/parser-extension-api
>
> Thanks!
>

The first part, describing https://github.com/nikic/php-ast , looks fine.
I see no problems including this extension into PHP-7.0 core distribution.
May be even making it required (like ext/reflection).

Nikita, what do you think?

The second part looks very interesting, however it has some uncovered
questions.
- API for AST modification
- AST validation (someone may insert "break" node in "parameter-list").

If you have enough experience, I would suggest you to try writing an
external extension that would implement this idea.
If you'll need some modification in PHP core (e.g adding callbacks), we may
consider including them in PHP-7.0.

Thanks. Dmitry.

--089e01538610829697050f56d9f5--