Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82989
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.192.172 as permitted sender)
Message-ID: <54E37669.9060805@lerdorf.com>
Date: Tue, 17 Feb 2015 09:12:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Sara Golemon <pollita@php.net>
CC: francois@php.net, Philip Sturgeon <pjsturgeon@gmail.com>, 
 Arvids Godjuks <arvids.godjuks@gmail.com>,
 Jefferson Gonzalez <jgmdev@gmail.com>, 
 Rowan Collins <rowan.collins@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <011801d04a07$83ab1c00$8b015400$@php.net>	<CABDNdAFQsbo-A-gijPCwYDOf3ts-yKpP0tAL--WUaLU26GB-AQ@mail.gmail.com>	<016f01d04a3a$e9183220$bb489660$@php.net>	<CAESVnVoM7YbmXA8hTG1O66j+6YX3Xx2Q3uj_F=TPjHA4ws=8JA@mail.gmail.com>	<54E290E5.3020508@lerdorf.com>	<CAESVnVpXmmfDh6iqT=n27iHQ21_QxPWkez_=bEc1Dpn+MNrjMg@mail.gmail.com>	<54E2AD88.6040206@lerdorf.com>	<CAESVnVoFD7-A2_a1ZPR9av2tiVbbs7D0NUt0TihH-dQFvhkH6Q@mail.gmail.com>	<54E2FA57.6050009@lerdorf.com> <CAESVnVqjGJS8rJaYyrEkX-Y6KCaM=e+z9xEYyH9A7NkgYO0YAw@mail.gmail.com>
In-Reply-To: <CAESVnVqjGJS8rJaYyrEkX-Y6KCaM=e+z9xEYyH9A7NkgYO0YAw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="68ufnSCMFe8d81UF00oWx6KbPEKCGJsiQ"
Subject: Re: [PHP-DEV] Reviving scalar type hints
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--68ufnSCMFe8d81UF00oWx6KbPEKCGJsiQ
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/17/2015 08:38 AM, Sara Golemon wrote:
> On Tue, Feb 17, 2015 at 12:22 AM, Rasmus Lerdorf <rasmus@lerdorf.com> w=
rote:
>> Please correct me here if I somehow ran these incorrectly. I did put
>> some deliberate type errors into my userspace code and hh_client caugh=
t
>> those nicely, so it seems like it was working, but it didn't catch
>> anything when it came to calling the internal API functions.
>>
> The mechanisms are strict, but the definitions, in hack, are untyped,
> so there's nothing to validate:
>=20
> hphp/hack/hhi/stdlib/builtins_string.hhi:
>   function number_format($number, $decimals =3D 0, $dec_point =3D ".",
> $thousands_sep =3D ",");

Right, so most of the internal API functions were omitted from strict
typing in Hack it looks like except for some places where it made sense
to selectively apply stricter checks. The RFC as it stands doesn't give
us this option which is my major problem with it.

> Perhaps a ZEND_ACC_STRICT flag which lets an API opt-in to strict mode?=

> Or something passed to the arg_info struct? The details are secondary,
> but you get my meaning...

Yes, something along those lines to allow gradual and selective strictnes=
s.

The internal/extension api is just another library and the authors of
these library functions should have the same allowance as userspace
library authors. Like you said in one reply, "What's yours is yours,
what's theirs is theirs."

-Rasmus


--68ufnSCMFe8d81UF00oWx6KbPEKCGJsiQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlTjdmkACgkQlxayKTuqOuBFlQCeML97Qb84zm3vG5axFfum1E3/
9OEAn2hv7lSNEiCFB+ozweZdAIv7O9Vo
=zcIA
-----END PGP SIGNATURE-----

--68ufnSCMFe8d81UF00oWx6KbPEKCGJsiQ--