Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82976
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_RDzXaLHuEHgZ9Bn6V-MnrnK4zA1PF+Rh_ijWpB4HrMA@mail.gmail.com>
References: <CAL=_i_=cYXf=yjy7y6pytg7M=pe5z8dKpriqJiG2mC_XiMXYXw@mail.gmail.com>
	<54E1C24B.6010806@googlemail.com>
	<CAL=_i_kuuj-q6L0n4vZC2BC_D5Y_yKbmyDVXpSWrTSTXqDBGoA@mail.gmail.com>
	<CA+9eiLvT9JN08hMjN6mH_-WHvB4h5QeAKr7QMSvpz-FmrQGUhQ@mail.gmail.com>
	<CAF+90c_RDzXaLHuEHgZ9Bn6V-MnrnK4zA1PF+Rh_ijWpB4HrMA@mail.gmail.com>
Date: Tue, 17 Feb 2015 19:51:49 +0400
Message-ID: <CA+9eiLuDxRRXe7HWzqg7dNSiDzaPANk0sENMvr6y-1WVvrcLjQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Joe Watkins <pthreads@pthreads.org>, Crypto Compress <cryptocompress@googlemail.com>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01628326457985050f4aae7c
Subject: Re: [PHP-DEV] RFC: Expectations
From: dmitry@zend.com (Dmitry Stogov)

--089e01628326457985050f4aae7c
Content-Type: text/plain; charset=UTF-8

On Tue, Feb 17, 2015 at 5:11 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Mon, Feb 16, 2015 at 4:47 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Nikita,
>>
>> it looks like a part of old implementation is not trivial with new AST
>> compiler.
>>
>> previously we translated assert(condition) into assert(condition,
>> "assert(condition)").
>> actually we just captured a part of input buffer and added missing string
>> argument.
>>
>> Is there a simple way to do the same now?
>>
>
> Not very simple, but we could store pointers/offsets to the start and end
> of the fcall in the ast node, similar to what is done with lex_pos for
> declarations: http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_ast.h#177
>
> It would be nice if we could have precise offset information for all nodes
> (this is particularly valuable if the ast is exposed to userland), but that
> would increase memory usage during compilation, not sure if it's worthwhile.
>
>
>> It's possible to convert AST into string using recursive pretty-printer.
>> It's not a simple task itself, but it may be reused for other things.
>>
>
I went by this way... :)
It must be ready soo.


>
>> Joe, the rest (including zero-cost assert) is implemented at
>> https://github.com/php/php-src/pull/1088/files
>> 9 related tests are failed for now.
>>
>
> As this is implemented right now, it would require writing \assert() in
> order to be zero-cost. Maybe we should disallow redefinition of assert as a
> namespaced function, so we can always optimize this?
>

good catch.

Thanks.


>
> Nikita
>

--089e01628326457985050f4aae7c--