Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82889
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLtJ+8UB8XhM8PFGtWtcUz015pnHJPVewVWy2xzdjk2Lxg@mail.gmail.com>
References: <CA+9eiLsxSpbdaa7Bpci2PRXQMRkTUiwZphjQYv2iDyXLUhrMow@mail.gmail.com>
	<CAEPJdukU+oWaH6jm=vk8chXbwUePsa3KPEXbgfx2BVxWBDbtig@mail.gmail.com>
	<CA+9eiLtJ+8UB8XhM8PFGtWtcUz015pnHJPVewVWy2xzdjk2Lxg@mail.gmail.com>
Date: Mon, 16 Feb 2015 22:07:19 +0100
Message-ID: <CAF+90c_h_rCDtaqOYgknc8kgF8ha487RNgQjFY-q6kUgJ8ijYA@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, PHP Internals <internals@lists.php.net>, 
	Guilherme Blanco <guilhermeblanco@gmail.com>, Pierrick CHARRON <pierrick@webstart.fr>, 
	Alexander Lisachenko <lisachenko.it@gmail.com>, Pierre Joye <pierre.php@gmail.com>, 
	Zeev Suraski <zeev@zend.com>, Andi Gutmans <andi@zend.com>, Joe Watkins <pthreads@pthreads.org>, 
	Yasuo Ohgaki <yohgaki@ohgaki.net>, Sebastian Bergmann <sebastian@php.net>, 
	Stanislav Malyshev <smalyshev@gmail.com>, Rasmus Lerdorf <rasmus@lerdorf.com>
Content-Type: multipart/alternative; boundary=047d7bfcf000c5462a050f3af87f
Subject: Re: [PHP-DEV] Annotations in PHP7
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7bfcf000c5462a050f3af87f
Content-Type: text/plain; charset=UTF-8

On Mon, Feb 16, 2015 at 10:02 PM, Dmitry Stogov <dmitry@zend.com> wrote:

>
>
> On Mon, Feb 16, 2015 at 11:05 PM, Benjamin Eberlei <kontakt@beberlei.de>
> wrote:
>
>>
>>
>> On Mon, Feb 16, 2015 at 12:07 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>>
>>> hi,
>>>
>>> During discussion of different ways of implementing "Design by Contract"
>>> we
>>> got an idea of using annotations.
>>>
>>> BTW: annotations are useful by their own and may be used for different
>>> purposes. Support for annotations was proposed long time ago:
>>>
>>> https://wiki.php.net/rfc/annotations
>>> https://wiki.php.net/rfc/annotations-in-docblock
>>> https://wiki.php.net/rfc/reflection_doccomment_annotations
>>>
>>> HHVM already implemented similar concept
>>>
>>> http://docs.hhvm.com/manual/en/hack.attributes.php
>>>
>>> I made a quick and dirty PoC that shows how we may implement annotations
>>> in
>>> PHP7 and how powerful they may be :
>>> https://gist.github.com/dstogov/dbf2a8f46e43719bd2c2
>>
>>
>> How about not exposing the AST, and then the userland can pass context to
>> a method $reflection->getAnnotation($name, $context);
>>
>> https://gist.github.com/beberlei/0dc36d4412b8e3454912
>>
>> That way AST is not exposed to userland.
>>
>
> Your example handles just particular use-case.
> I would like to provide a general solution.
>
> Thanks. Dmitry.
>

Could you provide some more info on how you would imagine this to be used
for the DbC use case? As far as I see, this would require injecting code
into the method body based on the annotations. Does that mean that
annotations handlers will get the chance to modify the AST of the method
itself during compilation? Or how is this supposed to be realized?

Nikita

--047d7bfcf000c5462a050f3af87f--