Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82877
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEPJdumyD2oTx4=4-jv_ZspU-9puUc2eZ-1C+JKNeWBn7okEiA@mail.gmail.com>
References: <CA+9eiLsxSpbdaa7Bpci2PRXQMRkTUiwZphjQYv2iDyXLUhrMow@mail.gmail.com>
	<CAB6YZuwu7_BKL-ztSwJN7Vr=ZYJqerOhgQrejyprjJy_9Ldy6Q@mail.gmail.com>
	<CAEPJdumyD2oTx4=4-jv_ZspU-9puUc2eZ-1C+JKNeWBn7okEiA@mail.gmail.com>
Date: Mon, 16 Feb 2015 20:09:14 +0100
Message-ID: <CAB6YZuz-H55uqmNxrKWj2pzykwEC48FxKDU6_xYUWavcb6=xhA@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: Dmitry Stogov <dmitry@zend.com>, PHP Internals <internals@lists.php.net>, 
	Nikita Popov <nikita.ppv@gmail.com>, Guilherme Blanco <guilhermeblanco@gmail.com>, 
	Pierrick CHARRON <pierrick@webstart.fr>, Alexander Lisachenko <lisachenko.it@gmail.com>, 
	Pierre Joye <pierre.php@gmail.com>, Zeev Suraski <zeev@zend.com>, Andi Gutmans <andi@zend.com>, 
	Joe Watkins <pthreads@pthreads.org>, Yasuo Ohgaki <yohgaki@ohgaki.net>, 
	Sebastian Bergmann <sebastian@php.net>, Stanislav Malyshev <smalyshev@gmail.com>, 
	Rasmus Lerdorf <rasmus@lerdorf.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Annotations in PHP7
From: pajousek@gmail.com (=?UTF-8?Q?Pavel_Kou=C5=99il?=)

On Mon, Feb 16, 2015 at 1:33 PM, Benjamin Eberlei <kontakt@beberlei.de> wro=
te:
>
>
> On Mon, Feb 16, 2015 at 1:17 PM, Pavel Kou=C5=99il <pajousek@gmail.com> w=
rote:
>>
>> On Mon, Feb 16, 2015 at 12:07 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>> > hi,
>> >
>> > During discussion of different ways of implementing "Design by Contrac=
t"
>> > we
>> > got an idea of using annotations.
>> >
>> > BTW: annotations are useful by their own and may be used for different
>> > purposes. Support for annotations was proposed long time ago:
>> >
>> > https://wiki.php.net/rfc/annotations
>> > https://wiki.php.net/rfc/annotations-in-docblock
>> > https://wiki.php.net/rfc/reflection_doccomment_annotations
>> >
>> > HHVM already implemented similar concept
>> >
>> > http://docs.hhvm.com/manual/en/hack.attributes.php
>> >
>> > I made a quick and dirty PoC that shows how we may implement annotatio=
ns
>> > in
>> > PHP7 and how powerful they may be :
>> > https://gist.github.com/dstogov/dbf2a8f46e43719bd2c2
>> >
>> > The test there is self explainable. Of course, annotations just provid=
e
>> > a
>> > way to add metadata, but doesn't define attribute names or the ways th=
ey
>> > are going to be used. Only Reflection API to read.
>> >
>> > There are still a lot of technical problems that have to be solved.
>> > Right now, we just need to answer a question - if we like this in PHP7=
?
>> > Thought and opinions are welcome...
>> >
>> > Thanks. Dmitry.
>>
>> Hello,
>>
>> I'd personally suggest you to consider that the Annotations could be
>> classes, something along the lines of
>>
>> https://msdn.microsoft.com/en-us/library/aa288454%28v=3Dvs.71%29.aspx#vc=
wlkattributestutorialanchor1
>>
>> IMHO it will allow for more usecases and such than simple arrays.
>
>
> They are statements, so you can do whatever. Dimitri just showed scalars,
> but it would be possible to do:
>
> <orm(new Entity(["repositoryClass" =3D> "FooRepository"]))>
>
> And then getAnnotations returns something along the lines if evaluated by
> the PHP Parser:
>
> "orm" =3D> [new Entity(....), ]
>
> So your requirement would be possible.
>>
>>
>> Regards
>> Pavel Kouril
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>

Hello,

while the usage of statements in annotations sound good in theory, I
find the need for using the "new" and such as ugly. Thefore, I'd
probably still prefer the C# style of doing annotations.

Regards
Pavel Kouril