Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82856
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAL=_i_kuuj-q6L0n4vZC2BC_D5Y_yKbmyDVXpSWrTSTXqDBGoA@mail.gmail.com>
References: <CAL=_i_=cYXf=yjy7y6pytg7M=pe5z8dKpriqJiG2mC_XiMXYXw@mail.gmail.com>
	<54E1C24B.6010806@googlemail.com>
	<CAL=_i_kuuj-q6L0n4vZC2BC_D5Y_yKbmyDVXpSWrTSTXqDBGoA@mail.gmail.com>
Date: Mon, 16 Feb 2015 19:47:34 +0400
Message-ID: <CA+9eiLvT9JN08hMjN6mH_-WHvB4h5QeAKr7QMSvpz-FmrQGUhQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Joe Watkins <pthreads@pthreads.org>, Crypto Compress <cryptocompress@googlemail.com>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01538610427fd1050f3681d2
Subject: Re: [PHP-DEV] RFC: Expectations
From: dmitry@zend.com (Dmitry Stogov)

--089e01538610427fd1050f3681d2
Content-Type: text/plain; charset=UTF-8

Hi Nikita,

it looks like a part of old implementation is not trivial with new AST
compiler.

previously we translated assert(condition) into assert(condition,
"assert(condition)").
actually we just captured a part of input buffer and added missing string
argument.

Is there a simple way to do the same now?

It's possible to convert AST into string using recursive pretty-printer.
It's not a simple task itself, but it may be reused for other things.

Joe, the rest (including zero-cost assert) is implemented at
https://github.com/php/php-src/pull/1088/files
9 related tests are failed for now.

Thanks. Dmitry.

On Mon, Feb 16, 2015 at 1:32 PM, Joe Watkins <pthreads@pthreads.org> wrote:

> > is there any penalty of catch-AssertionException-blocks? Are those
> eliminated in production code?
>
> Assertions should never be enabled in production code, the ability to catch
> (and enable by configuration) the exception serves the developer of the
> code during development only.
>
> The example code is bad, I'll clear this up.
>
> Cheers
> Joe
>
> On Mon, Feb 16, 2015 at 10:11 AM, Crypto Compress <
> cryptocompress@googlemail.com> wrote:
>
> > Hi Joe,
> >
> > is there any penalty of catch-AssertionException-blocks? Are those
> > eliminated in production code?
> >
> > Thanks
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>

--089e01538610427fd1050f3681d2--