Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82763
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.172 as permitted sender)
Message-ID: <54E1260F.2070101@gmail.com>
Date: Sun, 15 Feb 2015 23:04:47 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAJ26g5Swk1z2W-kR6FG77M1bPJPQjVUihd13-27ngwHK7A8+cA@mail.gmail.com>
In-Reply-To: <CAJ26g5Swk1z2W-kR6FG77M1bPJPQjVUihd13-27ngwHK7A8+cA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] A modest proposal: __contructStatic
From: rowan.collins@gmail.com (Rowan Collins)

On 15/02/2015 19:04, Patrick Schaaf wrote:
> By neccessity the implementation of this class set, must make use of both
> __call() and __callStatic() magic methods, with both then dispatching to a
> delegate phpredis instance, and in the case of __callStatic(), making
> up-front a singleton like "new self" once. For a set of additional helper
> methods (not present on the underlying phpredis) I additionally have a
> special mapping array of real method names to internal implementation names.

A quick thought - if you want to stick with the "magic static call" 
pattern, you can implement this much more simply by doing something 
similar to Laravel's "facades" [1]:

class MyRedis extends Redis {
// extra instance methods here
}

class MyRedisFacade {
private static $instance;
public static function __callStatic($method, $params) {
if ( is_null(self::$instance) ) {
self::$instance = new MyRedis;
}
self::$instance->$method(...$params);
}
}


This basically implements in userspace what you propose to add to the 
language, with the only caveat being that you must separate the concerns 
of adding extra functionality, and wrapping it in a static facade, into 
two separate classes.

[1] http://laravel.com/docs/4.2/facades

-- 
Rowan Collins
[IMSoP]