Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82747
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.180 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <CAEKnhAFnVawHOTsFW0wbLME_djEzSq0L_ExYy0jdBzhaHxbmLw@mail.gmail.com>
References: <CAEZPtU6yorwRtoC1zMiEMrvuB_+ijL+UOBNZ-YJHxFGanw+UXg@mail.gmail.com>
	<CABBJUpdqU=EvaZuYyp4=HxaM=uCw5drjxa_u6qqVR1bJSzeyMQ@mail.gmail.com>
	<CAEZPtU6pdCD-_0O3Xg8+YsbtbE4NHGS7q0EAewm8UBBY2B2_uw@mail.gmail.com>
	<CABBJUpdqiSNvqPcVQXyLmuJapphPDsSQDHHY2CJjZ7uinpAx6w@mail.gmail.com>
	<a82346245b54159f2b30061b9f200c39.squirrel@webmail.klapt.com>
	<CAEKnhAH7ctCOc+TcR+znTxhieGocWHXXKrtWH-0-27dsKyh1yQ@mail.gmail.com>
	<CAEZPtU5y6QH50yvNtH_R5GuJCtBwzpFKusQKS1s6sxBBWayUPw@mail.gmail.com>
	<CAEKnhAHLdN26ZayD6bXLWxBdebLhBnHR25QMpS1wqToev7F_+g@mail.gmail.com>
	<CABBJUpdCgbBkG_WCM=reC9opFYWVCQU0CHJ7b7c1c=YYTJ_yjA@mail.gmail.com>
	<CAEKnhAH5PnDhAW1LPGi6T25FA-Js8YkbBpK2HGxR4TktpnJ=tw@mail.gmail.com>
	<23dacb400dab7987ce59ba76826cfddf.squirrel@webmail.klapt.com>
	<CAEKnhAEjDSOOEneD4ZysN+zOSzUYCg35kO-TxED=C8VhNbnBzg@mail.gmail.com>
	<103ccee5476f5c444cf5b9d12969b036.squirrel@webmail.klapt.com>
	<CAEKnhAFnVawHOTsFW0wbLME_djEzSq0L_ExYy0jdBzhaHxbmLw@mail.gmail.com>
Date: Sun, 15 Feb 2015 20:18:16 +0000
Message-ID: <CAEKnhAG0FG_-0p6EFVzPPYU8AM5Pka=v8mbYgT4g=7NH+NRe0g@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Xinchen Hui <laruence@php.net>, Pierre Joye <pierre.php@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113ed1ce7bc54d050f262b10
Subject: Re: [PHP-DEV] new json, push generated file?
From: bukka@php.net (Jakub Zelenka)

--001a113ed1ce7bc54d050f262b10
Content-Type: text/plain; charset=UTF-8

On Wed, Feb 11, 2015 at 11:56 AM, Jakub Zelenka <bukka@php.net> wrote:
>
>
> I would like to push the the bison tab files shortly as the majority of
> people in this thread (including me) are for having them in the repo. The
> only thing that I would like is to have a specific version in the repo to
> prevent big diffs for small changes in the source files. For now I would
> like to have there re2c 0.13.6 (thanks for regenerating it back ;) ) and
> bison 2.7.1 gen files. I will update Readme at some point as well and add
> there that info.
>
>
Hey just a quick update. I bumped the version in the repo for re2c 0.13.7.5
(latest - no changes in generated states ) and bison to 3.0.4 . I updated
Readme as well.

I have pushed the bison files in
http://git.php.net/?p=php-src.git;a=commit;h=911f7b10b1f4c9529bc01580d298a93a5cd6bbd2
. There is an explanation why the C preprocessor guard macro names are file
system dependent. It means why there is
YY_PHP_JSON_YY_HOME_JAKUB_PROG_PHP_MASTER_EXT_JSON_JSON_PARSER_TAB_H_INCLUDED .
It's due to bison algorithm for creating such name. As I noted the only
solution that works for me is using different yacc.c skeleton. I have done
it in jsond in
https://github.com/bukka/php-jsond/commit/583619d7962fa57bf97dcdac4147d8b599a42672
where I have optional bison generation which means that I can stick with
one bison version and use custom skeleton file. This is however not
possible in the core where we allow range of bison versions which doesn't
play well with skeletons that are version specific.

When I committed the changes, something went wrong with pushing to github.
I hope that my commit hasn't screwed anything up. There is some permission
problem probably:

Total 5 (delta 3), reused 0 (delta 0)
remote: Welcome bukka.
remote: Changesets accepted. Thank you for your contribution.
remote:
remote: Attempting to push to mirror git@github.com:php/php-src.git
remote: Permission denied (publickey).
remote: fatal: Could not read from remote repository.
remote:
remote: Please make sure you have the correct access rights
remote: and the repository exists.
To git@git.php.net:php-src.git
   549c6fa..5f82c92  master -> master


Cheers

Jakub

--001a113ed1ce7bc54d050f262b10--