Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82738
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_eKH5Dj9eYoPjoeA6AmOGgXw127oVziv5QDYuW8PRVXQ@mail.gmail.com>
References: <CACwt+JdHCYYVMbuuAZ73N_sfOkQHJ7_EkOtPWtqJcNW7Xgjn3w@mail.gmail.com>
	<EE83CD8A-BAFA-43AC-8CD0-5F123BF96299@ajf.me>
	<93453174-E6A8-47C6-8AB6-A08858A7FC05@zend.com>
	<CAAyV7nH0BVvoq0XpGAX=ve2j9RwgUvti+DvR0c7v2BiALg4XWg@mail.gmail.com>
	<CA+9eiLtjz4hVYduhQkjo9p5swtQ2ke5Lqxxy50PZsbreQaR1tQ@mail.gmail.com>
	<CAF+90c_eKH5Dj9eYoPjoeA6AmOGgXw127oVziv5QDYuW8PRVXQ@mail.gmail.com>
Date: Sun, 15 Feb 2015 23:18:34 +0400
Message-ID: <CA+9eiLtoF=b_VJcGyhzVAT7y4QkTg3jJ-GZYEDz1Dp0Hqr0gdQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Anthony Ferrara <ircmaxell@gmail.com>, Zeev Suraski <zeev@zend.com>, Andrea Faulds <ajf@ajf.me>, 
	Patrick ALLAERT <patrickallaert@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113399e603638c050f255679
Subject: Re: [PHP-DEV] [VOTE] Scalar Type Hints
From: dmitry@zend.com (Dmitry Stogov)

--001a113399e603638c050f255679
Content-Type: text/plain; charset=UTF-8

Currently we perform checks in RECV opcode handlers.
Andrea's patch just adds a flag in zend_execute_data that tells what kind
of checks should be performed in the function.
With JIT it's difficult to generate any checks on call-site, because the
actual function may by unknown at compile-time (and even may be changed on
next request).

Thanks. Dmitry.

On Sun, Feb 15, 2015 at 9:50 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Sun, Feb 15, 2015 at 7:43 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Anthony,
>>
>> If you are working on JIT, you should understand that declare() switch to
>> strict typing can't improve anything, because it works on caller side and
>> in each function you now will have to generate code for both weak and
>> strict checks.
>>
>
> Why do these checks have to be generated in the function, instead of
> performing checks/casts at the call-site? Naively I would assume this to
> perform better, because you can make use of type-information around the
> call-site to elide checks/casts. Or does this have adverse effects due to
> larger code size or something like that?
>
> Nikita
>

--001a113399e603638c050f255679--