Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82694
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fischer.name from 62.179.121.40 cause and error)
Message-ID: <54DF8DEB.50402@fischer.name>
Date: Sat, 14 Feb 2015 19:03:23 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAOsHV+t=peeRbvXtDoPL2EnvWsQVHNtNYJ5h_e9VQLeLq-srDA@mail.gmail.com> <CAF+90c-4ZTpsoEfRjajtwjwVo+SaspxT1zEh0k5icLQj30JjNA@mail.gmail.com> <CAF+90c8GiZr+UOvfBRExvRcnmxE8Reu=WT8itkfGzGL-dkcr1w@mail.gmail.com> <CAOsHV+uW9n67651RszvJONnd3QwvrfeZeqJy9iPv0akemrYJGw@mail.gmail.com>
In-Reply-To: <CAOsHV+uW9n67651RszvJONnd3QwvrfeZeqJy9iPv0akemrYJGw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Spam_score: -2.9
X-Spam_score_int: -28
X-Spam_bar: --
X-Spam_report: Spam detection software, running on the system "scanner01.home", has
 identified this incoming email as possible spam.  The original message
 has been attached to this so you can view it (if it isn't spam) or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  > 2015-02-13 13:50 GMT-03:00 Nikita Popov <nikita.ppv@gmail.com>:
    >> use PhpParser\NodeVisitorAbstract; >> use PhpParser\Error; >> use PhpParser\Node;
    >> use PhpParser\Node\Name; >> use PhpParser\Node\Name\FullyQualified; >>
    use PhpParser\Node\Stmt\Namespace_; >> use PhpParser\Node\Stmt\Use_; >> use
    PhpParser\Node\Stmt\Class_; >> use PhpParser\Node\Stmt\Interface_; >> use
    PhpParser\Node\Stmt\Trait_; >> use PhpParser\Node\Stmt\Function_; >> use
   PhpParser\Node\Stmt\Const_; >> use PhpParser\Node\Stmt\Catch_; >> use PhpParser\Node\Stmt\TraitUse;
    >> use PhpParser\Node\Stmt\TraitUseAdaptation\Precedence; >> use PhpParser\Node\Expr\StaticCall;
    >> use PhpParser\Node\Expr\StaticPropertyFetch; >> use PhpParser\Node\Expr\ClassConstFetch;
    >> use PhpParser\Node\Expr\New_; >> use PhpParser\Node\Expr\Instanceof_;
   >> use PhpParser\Node\Expr\FuncCall; >> use PhpParser\Node\Expr\ConstFetch;
    >> >> Damn, this looks unwieldy. With this proposal it becomes: >> >> use
    PhpParser\{NodeVisitorAbstract, Error, Node}; >> use PhpParser\Node\{Name,
    Name\FullyQualified}; >> use PhpParser\Node\Stmt\{ >> Namespace_, Use_, Class_,
    Interface_, Trait_, Function_, >> Const_, Catch_, TraitUse, TraitUseAdaptation\Precedence};
    >> use PhpParser\Node\Expr\{ >> StaticCall, StaticPropertyFetch, ClassConstFetch,
    New_, >> Instanceof_, FuncCall, ConstFetch}; >> [...] 
 
 Content analysis details:   (-2.9 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
Subject: Re: [PHP-DEV][RFC][VOTE] Group Use Declarations
From: markus@fischer.name (Markus Fischer)

> 2015-02-13 13:50 GMT-03:00 Nikita Popov <nikita.ppv@gmail.com>:
>> use PhpParser\NodeVisitorAbstract;
>> use PhpParser\Error;
>> use PhpParser\Node;
>> use PhpParser\Node\Name;
>> use PhpParser\Node\Name\FullyQualified;
>> use PhpParser\Node\Stmt\Namespace_;
>> use PhpParser\Node\Stmt\Use_;
>> use PhpParser\Node\Stmt\Class_;
>> use PhpParser\Node\Stmt\Interface_;
>> use PhpParser\Node\Stmt\Trait_;
>> use PhpParser\Node\Stmt\Function_;
>> use PhpParser\Node\Stmt\Const_;
>> use PhpParser\Node\Stmt\Catch_;
>> use PhpParser\Node\Stmt\TraitUse;
>> use PhpParser\Node\Stmt\TraitUseAdaptation\Precedence;
>> use PhpParser\Node\Expr\StaticCall;
>> use PhpParser\Node\Expr\StaticPropertyFetch;
>> use PhpParser\Node\Expr\ClassConstFetch;
>> use PhpParser\Node\Expr\New_;
>> use PhpParser\Node\Expr\Instanceof_;
>> use PhpParser\Node\Expr\FuncCall;
>> use PhpParser\Node\Expr\ConstFetch;
>>
>> Damn, this looks unwieldy. With this proposal it becomes:
>>
>> use PhpParser\{NodeVisitorAbstract, Error, Node};
>> use PhpParser\Node\{Name, Name\FullyQualified};
>> use PhpParser\Node\Stmt\{
>>     Namespace_, Use_, Class_, Interface_, Trait_, Function_,
>>     Const_, Catch_, TraitUse, TraitUseAdaptation\Precedence};
>> use PhpParser\Node\Expr\{
>>     StaticCall, StaticPropertyFetch, ClassConstFetch, New_,
>>     Instanceof_, FuncCall, ConstFetch};
>>

It's only the former (existing) format which has benefits at all to me:

- cognitively *I* can much easier glance through to "find" something.
Because my eyes just have to scan up/down on the same character column

- It's not alphabetically sorted (which just is important to "find"
things for a human, IMHO). No problem! Good text editors allow to sort a
selected text area alphabetically. Good look trying that with the group
syntax; this requires manual labor work or tooling.

- Markus