Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82691
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <746466D2-F3DB-4561-8C78-8685CC8F7EE7@ajf.me>
References: <CABDNdAHHSVK86KmOoXZLX-iqgmGMNiLAT8-1iouirHWxWkihJg@mail.gmail.com>
	<54CC8E81.3020104@beccati.com>
	<CABDNdAHR-KShYcHNbzCB3d7dAgyxSi3g_j88y1NLdXyHDkGawg@mail.gmail.com>
	<CA+kxMuSmFTQhFfKksJL=z5OXU47QuJMV=CvywhOAu0+vJohT2g@mail.gmail.com>
	<746466D2-F3DB-4561-8C78-8685CC8F7EE7@ajf.me>
Date: Sat, 14 Feb 2015 10:34:40 -0500
Message-ID: <CABDNdAFPReA=rbf2Ahf58=TRO67L6_CvbkvDZHs6cYx0ATKXjQ@mail.gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] ReflectionParameter::getClassName()
From: pjsturgeon@gmail.com (Philip Sturgeon)

On Sat, Jan 31, 2015 at 8:27 PM, Andrea Faulds <ajf@ajf.me> wrote:
>
>> On 1 Feb 2015, at 01:23, Dan Ackroyd <danack@basereality.com> wrote:
>>
>> On 31 January 2015 at 17:31, Philip Sturgeon <pjsturgeon@gmail.com> wrote:
>>> On Sat, Jan 31, 2015 at 3:12 AM, Matteo Beccati <php@beccati.com> wrote:
>>>>
>>>> 2) There's a tiny bit of overlap with "scalar type hints",
>>>
>>> 2) There might be some overlap in the scalar type hint stuff kinda,
>>> but I'd like to think there isn't. getClassName() is just
>>> getClass()->name
>>
>>
>> I think Matteo's point is that if any scalar type RFC passes, a
>> type-hint for a parameter would not always be the name of a class, so
>> the method name 'getClassName()' would be misleading.
>>
>> It would be good to choose a better name to avoid that problem.
>
> We already have that problem (array, callable).
>
> I think the more important issue is the conflict with the ReflectionTypeAnnotation RFC, which proposes something similar to what was originally part of the Return Types RFC:
>
> https://wiki.php.net/rfc/reflectionparameter.typehint
>
> Thanks.
>
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>

Hey, missed a few replies.

1. There is no conflict with scalar types at all. The class name is
not a scalar type :) We already have getClass(), this is just getting
the name of that class without loading it.


> a type-hint for a parameter would not always be the name of a class, so
the method name 'getClassName()' would be misleading.

This wont be a problem Dan. getClass() wouldn't work if you call it on
a `foo(string $bar)`, and this will fall over too. The test and RFC
both show that.

So, are we good to vote?