Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82569
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH4Ph4+5mfFKqvmt-ySxfCQng0nWr5vQG6wbA4X3beP1=w@mail.gmail.com>
References: <CAF+90c8iVRU8-er+05CJqLb7Pg2viR_-zgwf5jmVyfVWx-+-8Q@mail.gmail.com>
	<54DCD8B7.40700@gmail.com>
	<CAF+90c86tp4mVtvVjb+z=KExe+infVx0qaQ7S2-mfF=yrym5Vg@mail.gmail.com>
	<CAH-PCH4Ph4+5mfFKqvmt-ySxfCQng0nWr5vQG6wbA4X3beP1=w@mail.gmail.com>
Date: Fri, 13 Feb 2015 00:33:22 +0100
Message-ID: <CAF+90c9++BsFPOnn_hAxiFFDVbDujJiZURkBY04Q=ihKWR+9Fg@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Rowan Collins <rowan.collins@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b66f6dbb8a247050eec8b6d
Subject: Re: [PHP-DEV] Remove $this from incompatible context
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7b66f6dbb8a247050eec8b6d
Content-Type: text/plain; charset=UTF-8

On Fri, Feb 13, 2015 at 12:06 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

> adding the E_DEPRECATED was only about the assuming $this behavior:
> https://wiki.php.net/rfc/incompat_ctx
>

While the RFC may claim that, the way it was implemented will throw
E_DEPRECATED irregardless whether $this is used or not. As such all static
calls to non-static methods will currently throw a deprecation, if the call
happens from a non-static method. In practice you can leave off that last
restriction, because in codebases that don't use "static" annotations for
PHP 4 compatibility obviously all methods are non-static, so always
E_DEPRECATED will be thrown instead of E_STRICT.

Reverting this to E_STRICT means we undeprecate this again, which is
something I am certainly against.


> and the original plan for removing this behavior was simply to remove/not
> assume $this:
> "Even though I think an error at call site would be the most useful to the
> user, the most sensible option is to just have $this === null inside the
> callee, like when you do"
>

The RFC is not very clear on what is supposed to be implemented. I'm
proposing to go with the option "most useful to the user" here, while you
suggest to use what's referred to as "the most sensible option".

However, I am not willing to invest more time in this issue. I have decided
that I will implement this by nulling out $this and keeping the error
levels exactly as they are right now (a mix of E_STRICT and E_DEPRECATED).
I would have liked consistent error levels and I would have really liked
being nice to the user and giving him a error at the call site, instead of
a weird undefined variable notice which is even suppressed by default. But
in the end this is just not important enough for me to put up with all the
php internals crap.

Nikita

--047d7b66f6dbb8a247050eec8b6d--