Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82557
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54DD1BB1.1090501@gmail.com>
References: <CAF+90c8iVRU8-er+05CJqLb7Pg2viR_-zgwf5jmVyfVWx-+-8Q@mail.gmail.com>
	<54DD1BB1.1090501@gmail.com>
Date: Thu, 12 Feb 2015 22:39:09 +0100
Message-ID: <CAF+90c9yxSgSQt6antr=0AbL43sz5PNLcA1SHeY16zmvNEfO9g@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c22676430d9d050eeaf3a3
Subject: Re: [PHP-DEV] Remove $this from incompatible context
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11c22676430d9d050eeaf3a3
Content-Type: text/plain; charset=UTF-8

On Thu, Feb 12, 2015 at 10:31 PM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:

> Hi!
>
> > class A {
> >     // This is an *instance* method, but it doesn't actually use $this.
> >     // This kind of usage is very common in PHP 4 era code, where
> >     // "static" annotations weren't used
> >     function test() {
> >         echo "foo";
> >     }
> > }
> >
> > class B {
> >     function test2() {
> >         // This call would be forbidden because it assumes $this of class
> > B, when
> >         // calling an instance method of class A. However A::test() does
> > not actually
> >         // use $this!
> >         A::test();
> >     }
> > }
>
> IMHO, this should work. Maybe issue E_STRICT, but even then I'd think
> it's not really necessary, I can't see any purpose E_STRICT serves in
> this case - since $this is not used, no potential bug is averted, as the
> code works exactly as it was supposed to be working.
>
> > This case, where an incompatible $this will be assumed, but never
> actually
> > used, seems to be very common in PEAR, for example. Another weirdness of
> > forbidding this call is that the following very similar code would work
> and
> > only throw an E_STRICT notice:
> >
> > // NOT in a class
> > function test3() {
> >     A::test(); // E_STRICT
> > }
>
> Yes, this should work too, and I'm again not sure how useful is E_STRICT
> even here.
>
> > The compromise I'd like to implement instead is to only throw a fatal
> error
> > if $this is actually used in the called method and otherwise throw a
> > deprecation warning. Calls from instance methods, static methods and
>
> I would go even further and if $this is not there just let it work.
> Assuming $this from different context is broken, but if $this not
> involved, what's the harm? The call to different context should just
> drop $this and treat it as if it were a call from global scope.
>

It was always an E_STRICT error to call a non-static method statically (as
usual, not counting scoped calls) and since PHP 5.6 it was E_DEPRECATED in
the most common case. I don't see why we would suddenly want to go back on
this and make it work without any warnings.

Nikita

--001a11c22676430d9d050eeaf3a3--