Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82544
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
Message-ID: <54DCD8B7.40700@gmail.com>
Date: Thu, 12 Feb 2015 16:45:43 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAF+90c8iVRU8-er+05CJqLb7Pg2viR_-zgwf5jmVyfVWx-+-8Q@mail.gmail.com>
In-Reply-To: <CAF+90c8iVRU8-er+05CJqLb7Pg2viR_-zgwf5jmVyfVWx-+-8Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Remove $this from incompatible context
From: rowan.collins@gmail.com (Rowan Collins)

Nikita Popov wrote on 12/02/2015 14:24:
> Hi internals,
>
> As part of [1] and [2] we have decided to remove support for doing static
> calls to instance methods, if this would result in an incompatible $this
> variable to be used. When applying [3] this change we found that the change
> as originally intended may be too strict.

[snip]

> The compromise I'd like to implement instead is to only throw a fatal error
> if $this is actually used in the called method and otherwise throw a
> deprecation warning. Calls from instance methods, static methods and
> functions will all be handled the same.

[snip]

I'm definitely in favour of this over completely forbidding such calls.

The only thing I'd question is the use of E_DEPRECATED when the static 
call doesn't use $this. Is there actually any intent to change the 
behaviour in a future version? What is the advantage to doing so? It 
strikes me as rather like the case of "var" for properties, which had 
the deprecation notice removed.

I think it would make more sense to raise an E_STRICT, since the main 
purpose seems to be to discourage users making such calls.

Regards,
-- 
Rowan Collins
[IMSoP]