Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:82487 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57794 invoked from network); 11 Feb 2015 18:35:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2015 18:35:52 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.54 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.216.54 mail-qa0-f54.google.com Received: from [209.85.216.54] ([209.85.216.54:50361] helo=mail-qa0-f54.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DC/01-51722-701ABD45 for ; Wed, 11 Feb 2015 13:35:52 -0500 Received: by mail-qa0-f54.google.com with SMTP id x12so4018883qac.13 for ; Wed, 11 Feb 2015 10:35:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=bZYUDRoOkLV27fiKzxdJ9tx9WCF9oklxHjzle83JRDY=; b=n3k5ldycDPJVMQD50lUSZlXG9SleLclIPYMFS/7FMnfq6WxzoeUwf3nDBLSdRWBz8e YMhbcXFakcso8WMy5mwYHGitd8JfEzzCC55xIEE060oGHmIRBddkdCwtA0b/XOO2mprE p2c/XWPFE+Dq2d8PFMNSXg/v8tYHcZR+J88oasXDqy6obSq4ikWOV/D5HJCkVMClddIg jIAPS3kXqYJopdTqLUcxsfPG+aOwrsHQYNVCbxNm/rG8WummIH84DIDYfL3EacE+9Ag/ 9wLBVuzUnXAqgrgIQok+n4evomPv/C2XIGGKxNz1YNKh1TqjiX+mpTboS7ovaO2DGAhk I4pw== X-Received: by 10.224.60.193 with SMTP id q1mr65853991qah.86.1423679749126; Wed, 11 Feb 2015 10:35:49 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.229.250.195 with HTTP; Wed, 11 Feb 2015 10:35:07 -0800 (PST) In-Reply-To: References: Date: Thu, 12 Feb 2015 03:35:07 +0900 X-Google-Sender-Auth: 1Xwq8K5GARQd3xtHMfdrpNrtYfg Message-ID: To: Dmitry Stogov Cc: Xinchen Hui , reeze , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a1133dee6b87f6d050ed4453a Subject: Re: Proposal: Introduce a new macro:php_error_docref_ex() From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a1133dee6b87f6d050ed4453a Content-Type: text/plain; charset=UTF-8 Hi all, On Wed, Feb 11, 2015 at 8:15 PM, Dmitry Stogov wrote: > I don't think it'll improve something, and may complicate merging from > PHP5 (this is not a big issue, because merging is already not simple). > > In any case, the names should be swapped, to be used as: > > php_error_docref(E_WARNING, "recursion detected"); > > or > > php_error_docref_ex(NULL, E_WARNING, "recursion detected"); > > > also macros with __VA_ARGS__ may be not portable, s it should be > implemented differently. It's even better. +1 Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a1133dee6b87f6d050ed4453a--