Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82483
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.182 as permitted sender)
MIME-Version: 1.0
Sender: mike.php.net@gmail.com
In-Reply-To: <CAG1chopDMOGPjCn+mbSfyTwgc18Rrg+iUBX6f7ytu+iq970mBg@mail.gmail.com>
References: <CAG1choozBpeftir=Sv2C8pFrmEfEKpHTS1NCjqE4SdT8s4Seaw@mail.gmail.com>
	<CABBJUpdoj72FYW=67Xef-yvJcGAbNHvdcd47cwDL1bD7q5=-WA@mail.gmail.com>
	<CAG1choreWwirOg8WLbi7FgGQaLGOu4K0hfGH3_3p0N+EOr3Onw@mail.gmail.com>
	<CAGa2bXbBPKRQDHMWGdpWR9KVQmJB_97oy6zEi8troG1SMZjx-A@mail.gmail.com>
	<CABBJUpfFwD866KZjKg60ZBmy0V4pvbRkRsueGKMQwLqfDSpQ4w@mail.gmail.com>
	<CA+9eiLt9zQac72OckzLJfHcNBFaWkXvrBDkzw7-EuPfV8uNOWQ@mail.gmail.com>
	<CAG1chopDMOGPjCn+mbSfyTwgc18Rrg+iUBX6f7ytu+iq970mBg@mail.gmail.com>
Date: Wed, 11 Feb 2015 17:56:33 +0100
Message-ID: <CALJZF3goTiLXwjTBk406gEPngcRnsK0=0AaHxqHgHhuUSpJQ7g@mail.gmail.com>
To: reeze <reeze@php.net>
Cc: PHP Internals <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@ohgaki.net>, 
	Xinchen Hui <laruence@php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: multipart/alternative; boundary=001a11c37120c2d5c2050ed2e2ca
Subject: Re: [PHP-DEV] Re: Proposal: Introduce a new macro:php_error_docref_ex()
From: mike@php.net (Michael Wallner)

--001a11c37120c2d5c2050ed2e2ca
Content-Type: text/plain; charset=UTF-8

Why not leave it as it is? I mean, really, those five strokes?

Wherever it's going, I'm -1 on changing the meaning of the existing macro.
 On 11 Feb 2015 16:01, "reeze" <reeze@php.net> wrote:

> Hi,
>
> On 11 February 2015 at 19:15, Dmitry Stogov <dmitry@zend.com> wrote:
>
> > Hi,
> >
> > I don't think it'll improve something, and may complicate merging from
> > PHP5 (this is not a big issue, because merging is already not simple).
> >
> >
> Yes it just makes code looks a little better and cleaner.
>
> I didn't realized the merging problem. that might affect diffs  which
> changes php_error_docref()
>
>
> > In any case, the names should be swapped, to be used as:
> >
> >     php_error_docref(E_WARNING, "recursion detected");
> >
> > or
> >
> >     php_error_docref_ex(NULL, E_WARNING, "recursion detected");
> >
>
> Yes I prefer this too.
>
> But considering the merging problem, I think I should hold this idea of
> update all of those calls.
>
> We may provider a simple version with default null docref for external
> extesions, but I didn't have proper name for that.
>
>
> >
> >
> > also macros with __VA_ARGS__ may be not portable, s it should be
> > implemented differently.
> >
>
> Yes I should use ##__VA_ARGS__  instead.
>
>
> > Thanks. Dmitry.
> >
> >
> >
> > On Wed, Feb 11, 2015 at 11:41 AM, Xinchen Hui <laruence@php.net> wrote:
> >
> >> Hey:
> >>
> >> On Wed, Feb 11, 2015 at 4:35 PM, Yasuo Ohgaki <yohgaki@ohgaki.net>
> wrote:
> >> > Hi all,
> >> >
> >> > On Wed, Feb 11, 2015 at 5:21 PM, reeze <reeze@php.net> wrote:
> >> >>
> >> >> I think it is a cleanup, it works but there are too many duplication.
> >> it
> >> >> is the time to make the code clean and easier to understand.
> >> >
> >> >
> >> > I've never used other than NULL also.
> >> > Everyone is going to remove TSRM macros, it's right time to clean up.
> >> fine, if you want to change..
> >>
> >> please, _ex means extending,
> >>
> >> so the name should not be php_error_docref_ex...
> >>
> >> thanks
> >> >
> >> > Regards,
> >> >
> >> > --
> >> > Yasuo Ohgaki
> >> > yohgaki@ohgaki.net
> >>
> >>
> >>
> >> --
> >> Xinchen Hui
> >> @Laruence
> >> http://www.laruence.com/
> >>
> >
> >
>
>
> --
> Reeze Xia
> http://reeze.cn
>

--001a11c37120c2d5c2050ed2e2ca--