Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82468
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpfFwD866KZjKg60ZBmy0V4pvbRkRsueGKMQwLqfDSpQ4w@mail.gmail.com>
References: <CAG1choozBpeftir=Sv2C8pFrmEfEKpHTS1NCjqE4SdT8s4Seaw@mail.gmail.com>
	<CABBJUpdoj72FYW=67Xef-yvJcGAbNHvdcd47cwDL1bD7q5=-WA@mail.gmail.com>
	<CAG1choreWwirOg8WLbi7FgGQaLGOu4K0hfGH3_3p0N+EOr3Onw@mail.gmail.com>
	<CAGa2bXbBPKRQDHMWGdpWR9KVQmJB_97oy6zEi8troG1SMZjx-A@mail.gmail.com>
	<CABBJUpfFwD866KZjKg60ZBmy0V4pvbRkRsueGKMQwLqfDSpQ4w@mail.gmail.com>
Date: Wed, 11 Feb 2015 15:15:55 +0400
Message-ID: <CA+9eiLt9zQac72OckzLJfHcNBFaWkXvrBDkzw7-EuPfV8uNOWQ@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: Yasuo Ohgaki <yohgaki@ohgaki.net>, reeze <reeze@php.net>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c3ef8088fd43050ece2016
Subject: Re: Proposal: Introduce a new macro:php_error_docref_ex()
From: dmitry@zend.com (Dmitry Stogov)

--001a11c3ef8088fd43050ece2016
Content-Type: text/plain; charset=UTF-8

Hi,

I don't think it'll improve something, and may complicate merging from PHP5
(this is not a big issue, because merging is already not simple).

In any case, the names should be swapped, to be used as:

    php_error_docref(E_WARNING, "recursion detected");

or

    php_error_docref_ex(NULL, E_WARNING, "recursion detected");


also macros with __VA_ARGS__ may be not portable, s it should be
implemented differently.

Thanks. Dmitry.



On Wed, Feb 11, 2015 at 11:41 AM, Xinchen Hui <laruence@php.net> wrote:

> Hey:
>
> On Wed, Feb 11, 2015 at 4:35 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> > Hi all,
> >
> > On Wed, Feb 11, 2015 at 5:21 PM, reeze <reeze@php.net> wrote:
> >>
> >> I think it is a cleanup, it works but there are too many duplication. it
> >> is the time to make the code clean and easier to understand.
> >
> >
> > I've never used other than NULL also.
> > Everyone is going to remove TSRM macros, it's right time to clean up.
> fine, if you want to change..
>
> please, _ex means extending,
>
> so the name should not be php_error_docref_ex...
>
> thanks
> >
> > Regards,
> >
> > --
> > Yasuo Ohgaki
> > yohgaki@ohgaki.net
>
>
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>

--001a11c3ef8088fd43050ece2016--