Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:82460 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85695 invoked from network); 11 Feb 2015 08:41:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2015 08:41:56 -0000 Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.48 as permitted sender) X-PHP-List-Original-Sender: xinchen.h@zend.com X-Host-Fingerprint: 209.85.215.48 mail-la0-f48.google.com Received: from [209.85.215.48] ([209.85.215.48:34923] helo=mail-la0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3C/E1-33902-5C51BD45 for ; Wed, 11 Feb 2015 03:41:44 -0500 Received: by labgm9 with SMTP id gm9so1949089lab.2 for ; Wed, 11 Feb 2015 00:41:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=xYThgVQwRt60SoulJxyHdn0gF3QmhdNpY/q7K71Gz6Y=; b=iDBU7/U14Qn1IAP/F+359ttRMl4/5ch9p0eC8MU6AIv3A0SNVESBXMjBxzNGvIfizJ k+SVxTIhUdbMaZbI3iIXY6jOuifI0WzbQqp/T3YqYxVWZHqXVKNt85ilu3OzUKca8DJU Cn/BotExdRNdtDLK13RJW+a/lUsF9uuRDuOx5r76ECpgkIf4mZpuaBtquYoXXZdKHqdS gqvco7g7vyCqqrH9KZezOsPWfvnKGd8jHHr55JBci6G5mvsQMhFCOm9zvPYTcVuFvkKa LrPEIhejO513r3w4lY3M23VriTYJpan5cE9s8nKHslwb/AHRswrUfhdWeG5D0NMIjkdD 8b6Q== X-Gm-Message-State: ALoCoQl1MzW78yAOdmUm5RWZiE1tx4UNmG8Rf0C0TiRb6lVn4e0200Wn7ELNAGKC+SYihVptFB9ylu1Ei9gr8j/Uq7bEvpeO5dmy8XX6EXgi4dMyn2a2O3XHF7zDZgon/ciJ1jTDC4ua5nRIOsORMxJTZrEoX2gOwA== X-Received: by 10.152.207.37 with SMTP id lt5mr772766lac.38.1423644098401; Wed, 11 Feb 2015 00:41:38 -0800 (PST) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com. [209.85.217.175]) by mx.google.com with ESMTPSA id cb5sm41291lad.3.2015.02.11.00.41.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 00:41:37 -0800 (PST) Received: by mail-lb0-f175.google.com with SMTP id n10so1817779lbv.6 for ; Wed, 11 Feb 2015 00:41:36 -0800 (PST) X-Received: by 10.112.235.194 with SMTP id uo2mr27118097lbc.57.1423644096645; Wed, 11 Feb 2015 00:41:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.28.193 with HTTP; Wed, 11 Feb 2015 00:41:16 -0800 (PST) In-Reply-To: References: Date: Wed, 11 Feb 2015 16:41:16 +0800 Message-ID: To: Yasuo Ohgaki Cc: reeze , "internals@lists.php.net" , Dmitry Stogov Content-Type: text/plain; charset=UTF-8 Subject: Re: Proposal: Introduce a new macro:php_error_docref_ex() From: laruence@php.net (Xinchen Hui) Hey: On Wed, Feb 11, 2015 at 4:35 PM, Yasuo Ohgaki wrote: > Hi all, > > On Wed, Feb 11, 2015 at 5:21 PM, reeze wrote: >> >> I think it is a cleanup, it works but there are too many duplication. it >> is the time to make the code clean and easier to understand. > > > I've never used other than NULL also. > Everyone is going to remove TSRM macros, it's right time to clean up. fine, if you want to change.. please, _ex means extending, so the name should not be php_error_docref_ex... thanks > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net -- Xinchen Hui @Laruence http://www.laruence.com/