Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82448
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.172 as permitted sender)
MIME-Version: 1.0
Sender: reeze.xia@gmail.com
Date: Wed, 11 Feb 2015 16:07:38 +0800
Message-ID: <CAG1choozBpeftir=Sv2C8pFrmEfEKpHTS1NCjqE4SdT8s4Seaw@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>, 
	Xinchen Hui <laruence@php.net>, Yasuo Ohgaki <yohgaki@ohgaki.net>
Content-Type: multipart/alternative; boundary=001a11c3847473d62f050ecb80bc
Subject: Proposal: Introduce a new macro:php_error_docref_ex()
From: reeze@php.net (reeze)

--001a11c3847473d62f050ecb80bc
Content-Type: text/plain; charset=ISO-8859-1

Hi all,
     There  are a lot of code use  php_error_docref() macro, the first
parameter
mostly is NULL, before PHP7, it looks like:

*php_error_docref(NULL TSRML, E_WARNING, "recursion detected");*
in PHP7
*php_error_docref(NULL, E_WARNING, "recursion detected");*
looks better, but the first parameter look dumb.

I did a simple statics, there are:

Null docref: 2530
Not Null docref: 51

I searched on Github, it seems that almost all of the extension use NULL
docref.

So I propose add a new macro, like:  php_error_error_docref_ex(E_WARNING,
"xxx").
this could make code looks better and  the extension maintainer's easier.

Another option would be just update the php_error_docref() macro to remove
the docref parameter, default to NULL but not add a new macro.


What do you think about it?

[1] https://github.com/php/php-src/pull/1075

-- 
Reeze Xia
http://reeze.cn

--001a11c3847473d62f050ecb80bc--