Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:82416 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 15891 invoked from network); 11 Feb 2015 06:08:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2015 06:08:38 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.49 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.192.49 mail-qg0-f49.google.com Received: from [209.85.192.49] ([209.85.192.49:51281] helo=mail-qg0-f49.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E7/92-33902-5E1FAD45 for ; Wed, 11 Feb 2015 01:08:37 -0500 Received: by mail-qg0-f49.google.com with SMTP id q107so1193121qgd.8 for ; Tue, 10 Feb 2015 22:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=NrueQHbDPDWtwkOefnAKuo0q6XavJXRiuwk/Q6Fhsb4=; b=QzPzg0/FtZoMzFRKXaysPiu2CXxnYQtV7l7Cf8XW/4XANV274q7Mjb7khL8pPGGwxf El56nC3XU6fxHUBvrz9j0bzQ2QeajGSfP+CcpiY1FLYkmTpenEZLNZhQJIASM54NURXr /XfU6vjSV2AitvD2crM7zaaaTa00JGizNYbeqLxUHUQDnwpBxJx+/fp6gBsw6aGyTWum f5hSsljyHzam+Q3rpFUAQ5abtwGOtbWNVvWjV1iZQEy07GEaPoH8YZhbjgJ02q5WSA+v hdAQOZp+xCgq70DQpxWRT1kldDGDFZRrg+hZEkyJvY8eNxC1vSBH+IAelel4aErwuEBI DzWw== X-Received: by 10.140.109.164 with SMTP id l33mr58901809qgf.91.1423634914959; Tue, 10 Feb 2015 22:08:34 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.229.250.195 with HTTP; Tue, 10 Feb 2015 22:07:54 -0800 (PST) In-Reply-To: References: <54D3EE95.2080109@lerdorf.com> Date: Wed, 11 Feb 2015 15:07:54 +0900 X-Google-Sender-Auth: DdLf-6CeNRPWNuNRkfhHXxmE07o Message-ID: To: Rasmus Lerdorf Cc: PHP internals Content-Type: multipart/alternative; boundary=001a113a304e656aa0050ec9d572 Subject: Re: [PHP-DEV] Annotated PHP 5->7 extension diff From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a113a304e656aa0050ec9d572 Content-Type: text/plain; charset=UTF-8 Hi all, On Fri, Feb 6, 2015 at 10:38 AM, Yasuo Ohgaki wrote: > It looks like this: >> >> https://gist.github.com/anonymous/15cbc9947edb4f0a71fd >> > > It uses session save handler uses PS_MOD() which is legacy. > I may help to adopt PS_MOD_TIMESTAMP(). > It eliminates writes and boost session performance a lot if apps > do not update session data always. > My environment is [yohgaki@dev helm]$ rpm -q memcached memcached-1.4.17-3.fc21.x86_64 I've just built it with current master/php7 branch and I got Without Valgrind ===================================================================== FAILED TEST SUMMARY --------------------------------------------------------------------- Memcached::cas() with strange key [ext/memcached/tests/experimental/cas_invalid_key.phpt] Memcached::deleteByKey() [ext/memcached/tests/experimental/delete_bykey.phpt] Memcached::get() [ext/memcached/tests/experimental/get.phpt] Memcached::getByKey() with CAS [ext/memcached/tests/experimental/get_bykey_cas.phpt] Memcached::phpinfo() [ext/memcached/tests/experimental/moduleinfo.phpt] ===================================================================== ===================================================================== WARNED TEST SUMMARY --------------------------------------------------------------------- Memcached store, fetch & touch expired key [ext/memcached/tests/expire.phpt] (warn: XFAIL section but test passes) ===================================================================== With Valgrind ===================================================================== FAILED TEST SUMMARY --------------------------------------------------------------------- Memcached::cas() with strange key [ext/memcached/tests/experimental/cas_invalid_key.phpt] Memcached::deleteByKey() [ext/memcached/tests/experimental/delete_bykey.phpt] Memcached::get() [ext/memcached/tests/experimental/get.phpt] Memcached::getByKey() with CAS [ext/memcached/tests/experimental/get_bykey_cas.phpt] Memcached::phpinfo() [ext/memcached/tests/experimental/moduleinfo.phpt] ===================================================================== ===================================================================== WARNED TEST SUMMARY --------------------------------------------------------------------- Memcached store, fetch & touch expired key [ext/memcached/tests/expire.phpt] (warn: XFAIL section but test passes) ===================================================================== ===================================================================== LEAKED TEST SUMMARY --------------------------------------------------------------------- Memcached::set()/delete() UDP [ext/memcached/tests/experimental/get_udp.phpt] Memcached::setMultiByKey() [ext/memcached/tests/experimental/setmulti_bykey.phpt] Memcached::setMulti() [ext/memcached/tests/setmulti.phpt] ===================================================================== If this is normal, I'll ignore them all and start adopting new save handler API. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a113a304e656aa0050ec9d572--