Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82415
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.47 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXZ4K53=2H+qDLi4ps5tFr4mNwf0mJciyjBa7cNm94Z7BA@mail.gmail.com>
References: <CAGa2bXZsANJz_RvsBvC9yBhac+ukHYUngA=GjLOgcqTTPbpGhg@mail.gmail.com>
 <54D9BFDD.70105@beccati.com> <CAGa2bXZ4K53=2H+qDLi4ps5tFr4mNwf0mJciyjBa7cNm94Z7BA@mail.gmail.com>
Date: Wed, 11 Feb 2015 14:41:19 +0900
Message-ID: <CAGa2bXbZuz7bEkj8YYixr+C2pXA8Fv7QU8xQAZoT3e17vkThgw@mail.gmail.com>
To: Matteo Beccati <php@beccati.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c12f8c5157a2050ec976f5
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Script only includes
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c12f8c5157a2050ec976f5
Content-Type: text/plain; charset=UTF-8

Hi Matteo,

On Wed, Feb 11, 2015 at 12:48 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> On Tue, Feb 10, 2015 at 5:22 PM, Matteo Beccati <php@beccati.com> wrote:
>
>> On 10/02/2015 01:52, Yasuo Ohgaki wrote:
>>
>>> Some of you are tired with this topic, but please take a look the RFC
>>>
>>> [RFC] Script only includes - this is 3rd version.
>>> https://wiki.php.net/rfc/script_only_include
>>>
>>> Please let me know what you like or dislike.
>>>
>>
>> I understand you goal, but ini settings are *bad*. We need less of them,
>> not more.
>>
>> Developing applications or libraries that are resilient to all possible
>> "variants" in the ini settings is painful. It's a waste of time for both
>> users and developers trying to provide support.
>
>
> I proposed script()/script_once() at first. Considering new names that
> might
> break existing apps, I choose INI.
>
> The INI may be removed in the future, if include/require has an option.
> e.g.
>
> require string $filename [, bool $embed_mode_flag];
>
> Would you like me to include this change proposal in the RFC?
> Even if we have embed_mode_flag, we are better to have the INI option for
> a
> while for smooth migration.
>

How about remove 2 INIs in the future with this RFC?

script_embed=On/Off (New with this RFC)
allow_url_include=On/Off

I'll prepare patch that

require(_once) string $filename [, int $include_type];
include(_once) string $filename [, int $include_type];

Where $include_type are
  - PHP_INCLUDE_DEFAULT (default: no embed, no URL)
  - PHP_INCLUDE_EMBED (allow embed)
  - PHP_INCLUDE_URL (allow URL)

These types are combined like "PHP_INCLUDE_EMBED | PHP_INCLUDE_URL".

Then, above 2 INIs may be deprecated and remove in the future.
How about remove them by PHP 7.3.

What do you think?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c12f8c5157a2050ec976f5--