Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:82388 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35183 invoked from network); 10 Feb 2015 17:03:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Feb 2015 17:03:55 -0000 X-Host-Fingerprint: 92.66.168.50 unknown Received: from [92.66.168.50] ([92.66.168.50:25885] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 79/60-32490-AF93AD45 for ; Tue, 10 Feb 2015 12:03:54 -0500 To: internals@lists.php.net Date: Tue, 10 Feb 2015 18:03:52 +0100 Message-ID: References: <54D3EE95.2080109@lerdorf.com> X-Newsreader: Forte Agent 3.3/32.846 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Posted-By: 92.66.168.50 Subject: Re: [PHP-DEV] Re: Annotated PHP 5->7 extension diff From: phpdev@ehrhardt.nl (Jan Ehrhardt) Xinchen Hui in php.internals (Mon, 9 Feb 2015 14:49:43 +0800): >On Mon, Feb 9, 2015 at 5:06 AM, Jan Ehrhardt wrote: >> https://wiki.php.net/phpng-upgrading [snip] >> ib_link = (ibase_db_link *)zend_fetch_resource2(Z_RES_P(link_arg), >> link_id, LE_LINK, le_link, le_plink); >> >> But this is only an educated guess based on looking at changes in other >> extensions. At the moment I am struggling with the PHP7 translation of >> this block: >these are changes are made recently, I've updated the relates section >in that wiki. Thanks. The wiki now contains my educated guess with an alternative if you know nothing about link_arg's type. Could you apply the PHP7 changes to ext/interbase/interbase.c as well? The Wiki is inconsistent with the actual PHP7 sources at the moment... BTW, this seems to be a copy/paste error in the Wiki: - if (zend_hash_find(EG(class_table), Z_STRVAL_P(key),\ Z_STRLEN_P(key)+1, (void**)&ce_ptr) == SUCCESS) { + if ((func = zend_hash_find_ptr(ht, Z_STR_P(key))) != NULL) { Jan