Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82326
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEKnhAHLdN26ZayD6bXLWxBdebLhBnHR25QMpS1wqToev7F_+g@mail.gmail.com>
References: <CAEZPtU6yorwRtoC1zMiEMrvuB_+ijL+UOBNZ-YJHxFGanw+UXg@mail.gmail.com>
 <CABBJUpdqU=EvaZuYyp4=HxaM=uCw5drjxa_u6qqVR1bJSzeyMQ@mail.gmail.com>
 <CAEZPtU6pdCD-_0O3Xg8+YsbtbE4NHGS7q0EAewm8UBBY2B2_uw@mail.gmail.com>
 <CABBJUpdqiSNvqPcVQXyLmuJapphPDsSQDHHY2CJjZ7uinpAx6w@mail.gmail.com>
 <a82346245b54159f2b30061b9f200c39.squirrel@webmail.klapt.com>
 <CAEKnhAH7ctCOc+TcR+znTxhieGocWHXXKrtWH-0-27dsKyh1yQ@mail.gmail.com>
 <CAEZPtU5y6QH50yvNtH_R5GuJCtBwzpFKusQKS1s6sxBBWayUPw@mail.gmail.com> <CAEKnhAHLdN26ZayD6bXLWxBdebLhBnHR25QMpS1wqToev7F_+g@mail.gmail.com>
Date: Tue, 10 Feb 2015 10:47:36 +0800
Message-ID: <CABBJUpdCgbBkG_WCM=reC9opFYWVCQU0CHJ7b7c1c=YYTJ_yjA@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Cc: Pierre Joye <pierre.php@gmail.com>, Anatol Belski <anatol.php@belski.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] new json, push generated file?
From: laruence@php.net (Xinchen Hui)

Hey:

On Tue, Feb 10, 2015 at 3:19 AM, Jakub Zelenka <bukka@php.net> wrote:
> On Mon, Feb 9, 2015 at 1:55 PM, Pierre Joye <pierre.php@gmail.com> wrote:
>>
>> I still think it is better to have this file applied. It is not like they
>> will change every 2nd day.
>
> Hi,
>
> I think that I might have solution for this and also for my another build
> problem which is re2c version.
>
> I have just created a PR where I tried to explain everything:
>
> https://github.com/php/php-src/pull/1072
>
> Basically ti adds all sources but allows to regenerate them only if the
> options --enable-json-filegen is set (more details are in the description).
>
> The config changes are just for Linux as I'm not sure how to do it on win
> and if it's even needed (if someone will send any patches to json scanner or
> parser and needs to generate them automatically).
>
> I'll keep the PR open for a week or so and if there are no objection, I
> would like merge it. I'm also open changing the name of the option and will
> be glad for any config.m4 related comments and reviews.
why make this thing in this way complicated? why not just simply
include the generated files as others did?

thanks
>
> Cheers
>
> Jakub
>



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/