Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:82309 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 16302 invoked from network); 9 Feb 2015 19:19:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Feb 2015 19:19:22 -0000 Authentication-Results: pb1.pair.com header.from=jakub.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=jakub.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.181 as permitted sender) X-PHP-List-Original-Sender: jakub.php@gmail.com X-Host-Fingerprint: 209.85.213.181 mail-ig0-f181.google.com Received: from [209.85.213.181] ([209.85.213.181:52299] helo=mail-ig0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4F/44-25034-93809D45 for ; Mon, 09 Feb 2015 14:19:22 -0500 Received: by mail-ig0-f181.google.com with SMTP id hn18so18575804igb.2 for ; Mon, 09 Feb 2015 11:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=nzXcf1fGspr9Mvxfy79GUruSvyul7979j09ZkwlbLa4=; b=J6aodvdM27wLSs/EoleVWoq6k7KpihabYXbTh+yo51NAJPRiPLUMPI6/gnSWt90o7g bPlddusoC2x2LQCSAcNcIhv+0MlUilLaJYoZjpuD4NY3KmWRPcZv4vKz2ZTweIKdslpG 9uO+H4RGnfmB7P9XrgexUYZ/ccv0Q/65a4BnVXwGJMG2HIjcShLjHUIi+n12KD63+7iu SqFpoUvoMxVmCVvytdTargED7kUqbB0/OKrIpQqu24OCw3bNvdNOrUci7ORjAeZQdBTF 5RAHyhRSodFiMvAclkAwaq7DKdSWLB1jk11m+IVP5FZijW6VVIsvSF1WbyoclHI+whB8 s1tA== MIME-Version: 1.0 X-Received: by 10.107.135.216 with SMTP id r85mr7255060ioi.38.1423509558993; Mon, 09 Feb 2015 11:19:18 -0800 (PST) Sender: jakub.php@gmail.com Received: by 10.107.169.216 with HTTP; Mon, 9 Feb 2015 11:19:18 -0800 (PST) In-Reply-To: References: Date: Mon, 9 Feb 2015 19:19:18 +0000 X-Google-Sender-Auth: VN0B9T4YeqS4NxEv0fTNZOYK69k Message-ID: To: Pierre Joye Cc: Anatol Belski , PHP internals , Xinchen Hui Content-Type: multipart/alternative; boundary=001a113fc1ec992917050eaca53b Subject: Re: [PHP-DEV] new json, push generated file? From: bukka@php.net (Jakub Zelenka) --001a113fc1ec992917050eaca53b Content-Type: text/plain; charset=UTF-8 On Mon, Feb 9, 2015 at 1:55 PM, Pierre Joye wrote: > I still think it is better to have this file applied. It is not like they > will change every 2nd day. > Hi, I think that I might have solution for this and also for my another build problem which is re2c version. I have just created a PR where I tried to explain everything: https://github.com/php/php-src/pull/1072 Basically ti adds all sources but allows to regenerate them only if the options --enable-json-filegen is set (more details are in the description). The config changes are just for Linux as I'm not sure how to do it on win and if it's even needed (if someone will send any patches to json scanner or parser and needs to generate them automatically). I'll keep the PR open for a week or so and if there are no objection, I would like merge it. I'm also open changing the name of the option and will be glad for any config.m4 related comments and reviews. Cheers Jakub --001a113fc1ec992917050eaca53b--