Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82249
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
Message-ID: <a82346245b54159f2b30061b9f200c39.squirrel@webmail.klapt.com>
In-Reply-To:
 <CABBJUpdqiSNvqPcVQXyLmuJapphPDsSQDHHY2CJjZ7uinpAx6w@mail.gmail.com>
References:
    <CAEZPtU6yorwRtoC1zMiEMrvuB_+ijL+UOBNZ-YJHxFGanw+UXg@mail.gmail.com>
    <CABBJUpdqU=EvaZuYyp4=HxaM=uCw5drjxa_u6qqVR1bJSzeyMQ@mail.gmail.com>
    <CAEZPtU6pdCD-_0O3Xg8+YsbtbE4NHGS7q0EAewm8UBBY2B2_uw@mail.gmail.com>
    <CABBJUpdqiSNvqPcVQXyLmuJapphPDsSQDHHY2CJjZ7uinpAx6w@mail.gmail.com>
Date: Mon, 9 Feb 2015 10:18:15 +0100
To: "Xinchen Hui" <laruence@php.net>
Cc: "Pierre Joye" <pierre.php@gmail.com>,
 "PHP internals" <internals@lists.php.net>,
 "Jakub Zelenka" <bukka@php.net>
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] new json, push generated file?
From: anatol.php@belski.net ("Anatol Belski")

Hi,

On Mon, February 9, 2015 07:33, Xinchen Hui wrote:
> Hey:
>
>
>
>
> On Mon, Feb 9, 2015 at 1:44 PM, Pierre Joye <pierre.php@gmail.com> wrote:
>
>> On Mon, Feb 9, 2015 at 11:10 AM, Xinchen Hui <laruence@php.net> wrote:
>>
>>> Hey:
>>>
>>>
>>> On Mon, Feb 9, 2015 at 10:40 AM, Pierre Joye <pierre.php@gmail.com>
>>> wrote:
>>>
>>>> hi,
>>>>
>>>> Should we push json_parser.tab.c? Which is generated (re2c), just
>>>> like what is done in date or other?
>>>>
>>> I think we should, and also use a better name...(.tab.c?)
>>>
>>
>> that too :)
> simply, json_parser.c is good
>
> something like: https://gist.github.com/laruence/f33903266cec737088aa
>
I'd be for applying this as well. Also, just added the generation calls to
config.w32, but actulaly a checked in file were much simpler to handle.

Regards

Anatol