Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82232
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <mfpgdadok23pfi2uskecgmlv5g6a84bnt0@4ax.com>
References: <CAEZPtU6yorwRtoC1zMiEMrvuB_+ijL+UOBNZ-YJHxFGanw+UXg@mail.gmail.com>
	<mfpgdadok23pfi2uskecgmlv5g6a84bnt0@4ax.com>
Date: Mon, 9 Feb 2015 14:55:58 +0700
Message-ID: <CAEZPtU7EYAxDOHb3PiASaUWJGbGP10bMtwKBu+JAFvdr4BTAKQ@mail.gmail.com>
To: Jan Ehrhardt <phpdev@ehrhardt.nl>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Re: new json, push generated file?
From: pierre.php@gmail.com (Pierre Joye)

On Mon, Feb 9, 2015 at 2:48 PM, Jan Ehrhardt <phpdev@ehrhardt.nl> wrote:
> Pierre Joye in php.internals (Mon, 9 Feb 2015 09:40:21 +0700):
>>Should we push json_parser.tab.c? Which is generated (re2c), just like
>>what is done in date or other?
>
> Yes, you should. I ran into this problem when I tried to compile PHP7
> from git head. The Windows builds are currently broken:
> http://windows.php.net/downloads/snaps/master/r0698901/logs/make-nts-windows-vc11-x86-r0698901.html


Yes, that's where I notice it was not present when I was working on
fixing the build in the 1st place (adding re2c call on win)
-- 
Pierre

@pierrejoye | http://www.libgd.org