Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82216
Return-Path: <smalyshev@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 26645 invoked from network); 9 Feb 2015 03:45:41 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 9 Feb 2015 03:45:41 -0000
Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.178 as permitted sender)
X-PHP-List-Original-Sender: smalyshev@gmail.com
X-Host-Fingerprint: 209.85.192.178 mail-pd0-f178.google.com  
Received: from [209.85.192.178] ([209.85.192.178:42446] helo=mail-pd0-f178.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 9E/A3-26926-46D28D45 for <internals@lists.php.net>; Sun, 08 Feb 2015 22:45:41 -0500
Received: by pdjz10 with SMTP id z10so10756731pdj.9
        for <internals@lists.php.net>; Sun, 08 Feb 2015 19:45:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        bh=tJtQf86MH62+W1hHqGcVKFlPpffRg9NXgFBMPs/qo8U=;
        b=hDKIzJz1gcW31TqOEpcnvc0Zityh6Mdt0aG8O/+5lHok88DsRZk2tJPt/hCAibO7sa
         ikKWwS3hacUEWrX0qIAOptngSH51eAKF0YwwVsgu7R6T/uNNTQ/lqo7MaUu9rWyVjxKW
         wGly1Dbqf0YDsOb3ytVnJAERbXIrJTZjL2h+cFiwclwAqlBm3XFUQ0sMt6lxlPwyKN3M
         9YAS52eGpH1fB7E4dfuprcP0Xw8PnjmMdZy13KeS5xYaob2oY3pz5HcQxN+SBc337J6G
         NJi3EGnbq0dlyWOXmFITDUdjh5DVWdwEOdCIe3eZvv/N9F1dOqDMnpAsrANb3wtNCJ+f
         5b7w==
X-Received: by 10.66.65.234 with SMTP id a10mr25683988pat.120.1423453538431;
        Sun, 08 Feb 2015 19:45:38 -0800 (PST)
Received: from [192.168.2.145] (108-66-6-48.lightspeed.sntcca.sbcglobal.net. [108.66.6.48])
        by mx.google.com with ESMTPSA id n2sm14760519pdo.0.2015.02.08.19.45.37
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Sun, 08 Feb 2015 19:45:37 -0800 (PST)
Message-ID: <54D82D4F.3030909@gmail.com>
Date: Sun, 08 Feb 2015 19:45:19 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Pierre Joye <pierre.php@gmail.com>, 
 PHP internals <internals@lists.php.net>,
 Jakub Zelenka <bukka@php.net>
References: <CAEZPtU6yorwRtoC1zMiEMrvuB_+ijL+UOBNZ-YJHxFGanw+UXg@mail.gmail.com>
In-Reply-To: <CAEZPtU6yorwRtoC1zMiEMrvuB_+ijL+UOBNZ-YJHxFGanw+UXg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] new json, push generated file?
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Should we push json_parser.tab.c? Which is generated (re2c), just like
> what is done in date or other?

I think we should, otherwise building from release package without re2c
would be impossible, and I think before it was possible. In any case, we
should be consistent - if we commit generated files (which we do), we
should do it everywhere.

-- 
Stas Malyshev
smalyshev@gmail.com