Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82132
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54D6CC39.50708@lerdorf.com>
References: <8703B53E-2C4A-4AC6-95C4-D4F19C6D5221@ajf.me>
	<CAB6YZuy-FFERAqcOjtyiizzwUZb6qrnMw8FCf8zur1wsL37Opg@mail.gmail.com>
	<9E1C2427-0295-4F3E-BD29-04DA84321067@ajf.me>
	<A3ACFAAF-37CB-47ED-9605-BA7D0609E4DA@ajf.me>
	<CAB6YZuzW9zwV7F44_8BxcrcteFMW2c3GJq1bkUuZTC9-tcmtNQ@mail.gmail.com>
	<54D6CC39.50708@lerdorf.com>
Date: Sun, 8 Feb 2015 11:20:41 +0100
Message-ID: <CAF+90c-OXJh75kujhPpuA73o6tXKPMsz_v1mL8ZvqGiVPExswA@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: =?UTF-8?Q?Pavel_Kou=C5=99il?= <pajousek@gmail.com>, 
	Andrea Faulds <ajf@ajf.me>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134c9028252ef050e9101fa
Subject: Re: [PHP-DEV] [VOTE] Scalar Type Hints
From: nikita.ppv@gmail.com (Nikita Popov)

--001a1134c9028252ef050e9101fa
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 8, 2015 at 3:38 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> On 02/07/2015 05:03 PM, Pavel Kou=C5=99il wrote:
> > I'm wishing more and more that the RFC doesn't pass (even though I'd
> > LOVE to have typehints in PHP as a userland developer) and someone
> > else will make a better version of typehints RFC for  PHP 7, because
> > this one feels really like you took an ok-ish RFC (one that would be
> > good for PHP) and slapped a strict typing on it without enough
> > research about strong typing in other languages. And as I said myself
> > multiple times in the past, the declare syntax IS just ugly (and
> > changing how code works by writing one line is an ugly principle as
> > well, IMHO). :(
>
> I am not sure I would go that far. Andrea did plenty of research and has
> tons of experience in other languages, I just think this approach is
> misguided. I also wonder just how many people of those who voted even
> bothered to download and try the patch. I tried it a while back on some
> existing code and it was a nightmare. Does everyone realize that these
> simple things break?
>
>  tan(1);
>  echo strstr("test", "est", 1);
>

Seems like a case where one mans bug is another mans feature. While
int->float conversions are debatable (and the answer may not be obvious if
you consider bigints) I would definitely want the latter call to error.
Seeing strstr("test", "est", 1) I would obviously assume that 1 is an
offset parameter, like it is the case with many other str* family
functions. strstr("test", "est", true) is a lot more obvious and I'll be
happy if PHP yells at me if I'm sacrificing three keystrokes for a lot of
readability.


> Basically declare() does not respect function scope, but it doesn't let
> you know that. There is a reason we haven't used declare() for anything
> real.
>

This sounds like a bug more than anything else. It can be easily fixed.

Nikita

--001a1134c9028252ef050e9101fa--