Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82064
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
Message-ID: <5c7f69a8531abbdedcb87e0ad9f60161.squirrel@webmail.klapt.com>
In-Reply-To:
 <CA+kxMuRx_KCB5_A0WZRnUYKRB=gAxd3Y8wP=0iPTwF2-OiJSTQ@mail.gmail.com>
References: <54D3EE95.2080109@lerdorf.com>
    <CA+kxMuRx_KCB5_A0WZRnUYKRB=gAxd3Y8wP=0iPTwF2-OiJSTQ@mail.gmail.com>
Date: Fri, 6 Feb 2015 20:43:11 +0100
To: "Dan Ackroyd" <danack@basereality.com>
Cc: "Rasmus Lerdorf" <rasmus@lerdorf.com>,
 "PHP internals" <internals@lists.php.net>
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Annotated PHP 5->7 extension diff
From: anatol.php@belski.net ("Anatol Belski")

Hi Dan,

On Fri, February 6, 2015 17:16, Dan Ackroyd wrote:
> On 5 February 2015 at 22:28, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
>
>> Any suggestions for how to handle annotating it? We could turn it into
>> a fake PR and mark it up using github's PR comments.
>
> I think that's a good idea. It is very easy for people to ask
> questions about any change that they don't understand on the exact lines
> that are confusing them.
>
> Also, I found it useful when converting Imagick to have a checklist of
> everything that needed to be done, in a simple format, rather than the full
> explanation of the changes at https://wiki.php.net/phpng-upgrading. That
> allowed me to search for the things that needed fixing.
>
> You could then put links to the PR from checklist for an example of
> the change in place.
>
regarding your ext/imagick port, please check the make logs here
http://windows.php.net/downloads/pecl/snaps/imagick/3.2.0rc1/logs/ . How
it looks, you also might find this tool useful
https://github.com/johannes/clang-php-checker/ .

Thanks.

Anatol