Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82012
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54D3A8A1.70700@gmail.com>
References: <CA+sv8zC==OeU9nnzxM=65A24fV+WiTdhbJgqLg-u=wVhGtL9Zw@mail.gmail.com>
	<CA+sv8zB=c5j8iZDv9mocXfkUF57U+pUJxTGyMg9mj7FAuTKyjg@mail.gmail.com>
	<54D3A8A1.70700@gmail.com>
Date: Thu, 5 Feb 2015 23:49:00 -0500
Message-ID: <CA+sv8zAj91MxFtb-=eRVNzB4szOh7DbGtY6OyCYOAc3rD5jp-g@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1135e68c9de483050e6423c1
Subject: Re: [PHP-DEV] Re: Serialize generating corrupted data
From: jrbasso@gmail.com (Juan Basso)

--001a1135e68c9de483050e6423c1
Content-Type: text/plain; charset=UTF-8

Hi,

Thanks for the feedback.

I opened the pull request (https://github.com/php/php-src/pull/1057). Is
that correct?

On Thu, Feb 5, 2015 at 12:30 PM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:

> Hi!
>
> >> I can try to make a patch to solve it, but before that I would like how
> >> the behavior should be. Some options:
> >> 1) Give the notice saying the field doesn't exist and do not include on
> >> the serialized response
> >> 2) Give the notice saying the field doesn't exist and convert the value
> to
> >> string (ie, on my example the int(1) would be transformed to string(1))
>
> I'd try (2) if it doesn't work (which probably would be the case unless
> your object happens to have property named "42" somehow) then produce a
> notice and omit it. If __sleep returns wrong value completely - e.g.
> false, I'd produce a warning and serialize it as null.
> --
> Stas Malyshev
> smalyshev@gmail.com
>

--001a1135e68c9de483050e6423c1--