Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82000
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.174 as permitted sender)
Content-Type: text/plain; charset=gb2312
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Date: Fri, 6 Feb 2015 11:00:58 +0800
Message-ID: <A63EB64F-D7EE-4F4D-94EF-B6F173A5FC3B@gmail.com>
References: <54D3EE95.2080109@lerdorf.com> <CAGa2bXYC_LV8s70whycssBYQCCjHA0JrYiZhcH+sC2trgztmpw@mail.gmail.com>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>,
 PHP internals <internals@lists.php.net>
In-Reply-To: <CAGa2bXYC_LV8s70whycssBYQCCjHA0JrYiZhcH+sC2trgztmpw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Subject: Re: [PHP-DEV] Annotated PHP 5->7 extension diff
From: laruence@gmail.com (Xinchen Hui)



Sent from my iPhone

> On Feb 6, 2015, at 9:38 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>=20
> Hi Rasmus,
>=20
>> On Fri, Feb 6, 2015 at 7:28 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote=
:
>>=20
>> Having just finished porting php-memcached (with help from Xinchen) to
>> PHP7 I was wondering if it wouldn't be worthwhile to annotate the diff
>> and explain why each change was made. The extension is complicated
>> enough to cover most of the changes the bulk of extension authors need
>> to worry about.
>>=20
>> The diff is easy enough to grab:
>>=20
>>  git clone https://github.com/php-memcached-dev/php-memcached.git
>>  cd php-memcached
>>  git checkout php7
>>  git diff master php7
>>=20
>> It looks like this:
>>=20
>>  https://gist.github.com/anonymous/15cbc9947edb4f0a71fd
>=20
> It uses session save handler uses PS_MOD() which is legacy.
> I may help to adopt PS_MOD_TIMESTAMP().
> It eliminates writes and boost session performance a lot if apps
> do not update session data always.
>=20
nice=A3=ACthanks
btw did you bench your optimization on file handler against Wordpress?

Thanks
> Regards,
>=20
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net