Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81997 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 31033 invoked from network); 6 Feb 2015 01:39:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Feb 2015 01:39:34 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.216.42 mail-qa0-f42.google.com Received: from [209.85.216.42] ([209.85.216.42:62312] helo=mail-qa0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A9/0A-17766-55B14D45 for ; Thu, 05 Feb 2015 20:39:33 -0500 Received: by mail-qa0-f42.google.com with SMTP id dc16so8746564qab.1 for ; Thu, 05 Feb 2015 17:39:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=b2Cn6sWudEEv5man34hWDcZqOCdbtxgCI1hfSdMbevA=; b=Y6IDaHdr0TCEe1/Q5l9vu7xC3AbcY10pYZt8fnFNXPn2Defn03nYk2i43iSb9k8vFy 8gptoMP7puXi3o5pUqai1l7rsOF+lCFewvS4VsrdO4hVmDUuwYLno/gfL+O4LNSI1tcb 0mfGVdOadkP4Y2G85r6veqCHotpJNhW2iiLEyYG6ZIMbNUqJ+oKtvIxIVFSJC5ASagUp mqHQmcHuni+KkNrN2QKJHSiw9BKSYUtjzBdwPPCAbxTk0dez/yf03EWUtZHpk9id8wdu cMlx/dbpQ8bdlSb32HvQmo8iX/gJdXhrveUDMK7ZZWlzQs25KJ3MkJfCYiYREDzXJbBe D/nQ== X-Received: by 10.140.42.22 with SMTP id b22mr2626006qga.43.1423186770852; Thu, 05 Feb 2015 17:39:30 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.229.28.72 with HTTP; Thu, 5 Feb 2015 17:38:50 -0800 (PST) In-Reply-To: <54D3EE95.2080109@lerdorf.com> References: <54D3EE95.2080109@lerdorf.com> Date: Fri, 6 Feb 2015 10:38:50 +0900 X-Google-Sender-Auth: cWtLum650lp1buKHmjO47yFOcRI Message-ID: To: Rasmus Lerdorf Cc: PHP internals Content-Type: multipart/alternative; boundary=001a11c12d76ed12d7050e617dcb Subject: Re: [PHP-DEV] Annotated PHP 5->7 extension diff From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11c12d76ed12d7050e617dcb Content-Type: text/plain; charset=UTF-8 Hi Rasmus, On Fri, Feb 6, 2015 at 7:28 AM, Rasmus Lerdorf wrote: > Having just finished porting php-memcached (with help from Xinchen) to > PHP7 I was wondering if it wouldn't be worthwhile to annotate the diff > and explain why each change was made. The extension is complicated > enough to cover most of the changes the bulk of extension authors need > to worry about. > > The diff is easy enough to grab: > > git clone https://github.com/php-memcached-dev/php-memcached.git > cd php-memcached > git checkout php7 > git diff master php7 > > It looks like this: > > https://gist.github.com/anonymous/15cbc9947edb4f0a71fd > It uses session save handler uses PS_MOD() which is legacy. I may help to adopt PS_MOD_TIMESTAMP(). It eliminates writes and boost session performance a lot if apps do not update session data always. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11c12d76ed12d7050e617dcb--