Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81982
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.208 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\))
In-Reply-To: <CA+kxMuQ-J=hg6fafJo85vfg3OTZ40XHRqsZTRDGNLfZ7XB5wMQ@mail.gmail.com>
Date: Thu, 5 Feb 2015 23:51:29 +0000
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <B46DC7C7-623F-4052-AF3F-AF8D203F6CE6@ajf.me>
References: <8703B53E-2C4A-4AC6-95C4-D4F19C6D5221@ajf.me> <CA+kxMuQ-J=hg6fafJo85vfg3OTZ40XHRqsZTRDGNLfZ7XB5wMQ@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Subject: Re: [PHP-DEV] [VOTE] Scalar Type Hints
From: ajf@ajf.me (Andrea Faulds)

Hi Dan,

> On 5 Feb 2015, at 23:41, Dan Ackroyd <danack@basereality.com> wrote:
>=20
> As much as I want scalar types I'm voting no as:
>=20
> i) Having this code:
>=20
> function foo(int $numberOfRightTurns) {
>    $x =3D $numberOfRightTurns * 90;
>    return sin(deg2rad($x))
> }
>=20
> work or blow up depending on a setting at the top of the file is =
horrible.

=46rom what I=E2=80=99ve seen this is a rather uncommon case.

Also, that code only works for some integer values and not others: the =
strict version is uniformly broken, the weak version is sometimes =
broken.

> ii) Having the code that I write in userland behave differently
> depending on how people call it, is also horrible.

Your code always behaves identically.

> Additionally Andrea, I am disappointed that you opened voting without
> a option with the 'declare' stuff removed. This is despite myself
> having asked you for an vote option for just strict types directly
> several times. Other people have asked for a vote option that allows
> strict and weak types with a different syntax.

Yes, I realise you and others have asked for such things. I disagree =
with you there and I don=E2=80=99t think adding strict types to PHP is =
really a good idea. I=E2=80=99d prefer we have more rather than less =
consistency between userland and internals.

> I realise that the RFC as it stands is your preferred option, but just
> not accepting feedback during an RFC is not appropriate.

I have listened to feedback. But listening to feedback and agreeing to =
any and all suggestions are not the same thing.
--
Andrea Faulds
http://ajf.me/