Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81969 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81639 invoked from network); 5 Feb 2015 22:41:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Feb 2015 22:41:33 -0000 Authentication-Results: pb1.pair.com header.from=guilhermeblanco@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=guilhermeblanco@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.182 as permitted sender) X-PHP-List-Original-Sender: guilhermeblanco@gmail.com X-Host-Fingerprint: 209.85.213.182 mail-ig0-f182.google.com Received: from [209.85.213.182] ([209.85.213.182:63663] helo=mail-ig0-f182.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0F/5E-27691-C91F3D45 for ; Thu, 05 Feb 2015 17:41:33 -0500 Received: by mail-ig0-f182.google.com with SMTP id h15so2427455igd.3 for ; Thu, 05 Feb 2015 14:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=DUjpHBBYIu79Ok0VnGDQ7iv1l3YARgbRs0Pt2iI8eYw=; b=E6Le3gc7AYU0jachmVbxyuqW4oNoNUfXuTXNaDYMBjNfkfvZ4LXqZ/bdHcD48F39b/ n56siIN7/pUVBieibwA75yMLx83ASazJiHvqfYa1Ds6zioJp8drDJyDRseGzqIg2mMdJ ieNRp4vMsjYqYqGl/U3aRpoJzGI7g0DIE5CG9J5A/QVhPmAjkHYx0/A5pASfdtuIP1i0 YOqyPN0m/1rzEXyr1yxbok5EnNrdhFjyqeRQmvr03a7wM97KyOAV28x3gpCEjp+gyOps NoI5xJcS6YEuxwA2zr4HAx+Tycsko+G2eouFiyN7y1aDcEAxRuWey13jVnJK6S1TAF2m RbDg== X-Received: by 10.42.200.82 with SMTP id ev18mr10000402icb.44.1423176090226; Thu, 05 Feb 2015 14:41:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.238.75 with HTTP; Thu, 5 Feb 2015 14:41:09 -0800 (PST) In-Reply-To: <54D3EE95.2080109@lerdorf.com> References: <54D3EE95.2080109@lerdorf.com> Date: Thu, 5 Feb 2015 17:41:09 -0500 Message-ID: To: Rasmus Lerdorf Cc: PHP internals Content-Type: multipart/alternative; boundary=20cf30223d835024e9050e5f0131 Subject: Re: [PHP-DEV] Annotated PHP 5->7 extension diff From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com") --20cf30223d835024e9050e5f0131 Content-Type: text/plain; charset=UTF-8 Hi Rasmus, Thanks for the highlight. My biggest concern about all this breakage done for NG could somehow be minimized by providing possible alternate implementations that could work both backwards compatible and forwards compatible? I just don't want to work on extensions I support that would never be usable in earlier versions once finished the update. Maybe it would be interesting to have samples of before/after (like you did) and also samples of of compatibility pieces for PHP 7- and PHP 7+. Regards, On Thu, Feb 5, 2015 at 5:28 PM, Rasmus Lerdorf wrote: > We have had quite a number of changes to the extension API and it > worries me a little bit how long it will take everyone to get their > extensions ported. We have UPGRADING.INTERNALS which still needs some > love, but even if that covered everything it is sometimes hard to match > a bullet point in a long list of changes to actual code. > > Having just finished porting php-memcached (with help from Xinchen) to > PHP7 I was wondering if it wouldn't be worthwhile to annotate the diff > and explain why each change was made. The extension is complicated > enough to cover most of the changes the bulk of extension authors need > to worry about. > > The diff is easy enough to grab: > > git clone https://github.com/php-memcached-dev/php-memcached.git > cd php-memcached > git checkout php7 > git diff master php7 > > It looks like this: > > https://gist.github.com/anonymous/15cbc9947edb4f0a71fd > > Any suggestions for how to handle annotating it? We could turn it into a > fake PR and mark it up using github's PR comments. But is there > something more suited for this out there? > > -Rasmus > > -- Guilherme Blanco MSN: guilhermeblanco@hotmail.com GTalk: guilhermeblanco Toronto - ON/Canada --20cf30223d835024e9050e5f0131--