Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81964
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.43 as permitted sender)
Message-ID: <54D3D577.2060607@gmail.com>
Date: Thu, 05 Feb 2015 12:41:27 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Anatol Belski <ab@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: BC break in headers_list
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi Anatol!

Your recent fixes to headers_list() -
55cefb2814bde5815a92e8820fff45e037fa8d4f and
b5d3c5ca8dee6303498849448e3574cc3642eeea - broke head.phpt test and also
are BC-breaking since previously headers_list() always returned an array
(empty one if there are no headers), now it returns false when there's
no headers. As the manual also says it returns array, I would rather
delete the RETURN_FALSE altogether. But if there's a good reason to
return false, the tests should be fixed and the notes in the UPGRADING
and the manual should be added.
I think just reverting to the previous behavior is better.
-- 
Stas Malyshev
smalyshev@gmail.com