Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81960
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.52 as permitted sender)
Sender: Michael Wallner <mike.php.net@gmail.com>
Message-ID: <54D3CE01.4070903@php.net>
Date: Thu, 05 Feb 2015 21:09:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Pierre Joye <pierre.php@gmail.com>
CC: PHP internals <internals@lists.php.net>, 
 Stas Malyshev <smalyshev@gmail.com>
References: <DDA98D4F-2105-415A-B921-01A622091FA9@php.net>	<54D217E7.8030407@php.net>	<54D2AE91.8090800@gmail.com>	<54D3271E.2080207@php.net> <CAEZPtU65NirGfES1qiic45Ui3qY45X+k370o2BSj3kbwLendjg@mail.gmail.com>
In-Reply-To: <CAEZPtU65NirGfES1qiic45Ui3qY45X+k370o2BSj3kbwLendjg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: [RFC] [DISCUSSION] pecl_http
From: mike@php.net (Michael Wallner)

Hi Pierre!

On 05/02/15 18:49, Pierre Joye wrote:
> 
> On Feb 5, 2015 3:17 PM, "Michael Wallner" <mike@php.net
> <mailto:mike@php.net>> wrote:
>>
>> Compare the timings accessing google 20 times sequentually:
>>
>> With default of raphf.persistent_handle.limit=-1 (unlimited):
>> █ mike@smugmug:~$ time php -r 'for ($i=0;$i<20;++$i) {(new
>> http\Client("curl","google"))->enqueue(new http\Client\Request("GET",
>> "http://www.google.at/"))->send();}'
>>
>> 0.03s user 0.01s system 2% cpu 1.530 total
>>
>>
>> With raphf effectively disabled:
>> █ mike@smugmug:~$ time php -d raphf.persistent_handle.limit=0 -r 'for
>> ($i=0;$i<20;++$i) {(new http\Client("curl","google"))->enqueue(new
>> http\Client\Request("GET", "http://www.google.at/"))->send();}'
>>
>> 0.04s user 0.01s system 1% cpu 2.790 total
> 
> While I like the idea, I would not take it as it. Many things could
> affect it and I am not sure the persistent resource is what spare times.
> Any profiling info with delta?
> 

Does the following kcachegrind screenshot give an idea (I used a minimum
node cost of 10% to simplify the graph)?

Left is raphf enabled (24M Ir) and on the right raphf disabled (35M Ir):
http://dev.iworks.at/ext-http/raphf.png

Have a look on the top-most far-right highlighted block, which is solely
devoted to tearing up curl instances when raphf is disabled.

-- 
Regards,
Mike