Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81870
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.179 as permitted sender)
MIME-Version: 1.0
Sender: reeze.xia@gmail.com
In-Reply-To: <CA+9eiLuxAfnop1DbDzDKNn=73Rkq1wA=de-TGTV2tiWsXU35qQ@mail.gmail.com>
References: <CAG1choqqmn=Ut9g6Y-Ss3JOUc-yNZTQ5Beyc9sCmEROR2vSpyA@mail.gmail.com>
 <CAG1choo=Hf=wQezrgBvUTACHamT4P0jn7rPWts7URHr7Za_LMg@mail.gmail.com>
 <CA+9eiLuWrftvOj6GDTiPcf+VZYWZGgtpHstg39CM-=gge21ZLA@mail.gmail.com>
 <CAG1choq7hAo6oFQb4OEFFdT46E6DAEVazFzfOeHiH3z-iaEimA@mail.gmail.com> <CA+9eiLuxAfnop1DbDzDKNn=73Rkq1wA=de-TGTV2tiWsXU35qQ@mail.gmail.com>
Date: Thu, 5 Feb 2015 16:05:54 +0800
Message-ID: <CAG1chorANVpvTZPefuO0sjWk1NSTf6AwT_qGgpoZRoEFvMeSkw@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b5d4fe22b22a5050e52c739
Subject: Re: [PHP-DEV] Re: [RFC] Support internal function return types
From: reeze@php.net (reeze)

--047d7b5d4fe22b22a5050e52c739
Content-Type: text/plain; charset=ISO-8859-1

Thanks a lot!

On 5 February 2015 at 16:03, Dmitry Stogov <dmitry@zend.com> wrote:

> merged into master with the proposed changes.
>
> Thanks. Dmitry.
>
> On Thu, Feb 5, 2015 at 9:37 AM, reeze <reeze@php.net> wrote:
>
>> Hi Dmitry,
>>
>> On 5 February 2015 at 14:31, Dmitry Stogov <dmitry@zend.com> wrote:
>>
>>> Hi reeze,
>>>
>>> The original "return type" patch was designed to support internal
>>> functions as well.
>>> So I think, this is just a good addition.
>>>
>> Yes :)
>>
>>>
>>> Only one note:
>>> I'm not sure, if we need the addition check in ZEND_DO_FCALL handler.
>>> On one hand it verifies that internal function returns proper result
>>> (but they MUST do it).
>>> On the other hand, it also slowdowns each additional call.
>>>
>>> Instead of modifying zend_verify_return_type() I would add
>>> zend_verify_internal_return_type(),
>>> and use: ZEND_ASSERT((fbc->common.fn_flags & ZEND_ACC_HAS_RETURN_TYPE)
>>> && zend_verify_internal_return_type(fbc, EX_VAR(opline->result.var)));
>>>
>>> This would allow catching error in DEBUG build, but won't slowdown
>>> RELEASE build.
>>>
>>> If you agree, I may just commit this.
>>>
>>
>> Sure!  Thank you!
>>
>>
>>>
>>> Thanks. Dmitry.
>>>
>>> On Thu, Feb 5, 2015 at 7:01 AM, reeze <reeze@php.net> wrote:
>>>
>>>> PS:
>>>>
>>>> There is no enough unit tests to cover all of the branches, if we want
>>>> then
>>>> I have to add a bunch of for testing functions and classes in
>>>> ZEND_DEBUG,
>>>> what is the better way?
>>>>
>>>> On 5 February 2015 at 11:54, reeze <reeze@php.net> wrote:
>>>>
>>>> > Hi all,
>>>> >
>>>> > RFC:  https://wiki.php.net/rfc/internal_function_return_types
>>>> >
>>>> > I noticed that return types RFC[1] didn't support internal functions,
>>>> I
>>>> > just open a PR[2]  to support it.
>>>> >
>>>> > There are some open issues we can discuss:
>>>> >
>>>> > 1. User land return types didn't stop the php, the current
>>>> implementation
>>>> > raise error to stop PHP from start, this may help debug problem.
>>>> > 2. User land return types didn't support Nullable types, but the RFC
>>>> > return types internally support it, I think it is feature. is that
>>>> > acceptable?
>>>> >
>>>> > Thank you.
>>>> >
>>>> > ---
>>>> >
>>>> > [1] https://wiki.php.net/rfc/return_types
>>>> > [2] https://github.com/php/php-src/pull/1050
>>>> >
>>>>
>>>
>>>
>>
>>
>> --
>> Reeze Xia
>> http://reeze.cn
>>
>
>


-- 
Reeze Xia
http://reeze.cn

--047d7b5d4fe22b22a5050e52c739--