Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81859
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.177 as permitted sender)
MIME-Version: 1.0
Sender: reeze.xia@gmail.com
In-Reply-To: <CAG1choqqmn=Ut9g6Y-Ss3JOUc-yNZTQ5Beyc9sCmEROR2vSpyA@mail.gmail.com>
References: <CAG1choqqmn=Ut9g6Y-Ss3JOUc-yNZTQ5Beyc9sCmEROR2vSpyA@mail.gmail.com>
Date: Thu, 5 Feb 2015 12:01:23 +0800
Message-ID: <CAG1choo=Hf=wQezrgBvUTACHamT4P0jn7rPWts7URHr7Za_LMg@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0122ae36abe34c050e4f5cbe
Subject: Re: [RFC] Support internal function return types
From: reeze@php.net (reeze)

--089e0122ae36abe34c050e4f5cbe
Content-Type: text/plain; charset=ISO-8859-1

PS:

There is no enough unit tests to cover all of the branches, if we want then
I have to add a bunch of for testing functions and classes in ZEND_DEBUG,
what is the better way?

On 5 February 2015 at 11:54, reeze <reeze@php.net> wrote:

> Hi all,
>
> RFC:  https://wiki.php.net/rfc/internal_function_return_types
>
> I noticed that return types RFC[1] didn't support internal functions, I
> just open a PR[2]  to support it.
>
> There are some open issues we can discuss:
>
> 1. User land return types didn't stop the php, the current implementation
> raise error to stop PHP from start, this may help debug problem.
> 2. User land return types didn't support Nullable types, but the RFC
> return types internally support it, I think it is feature. is that
> acceptable?
>
> Thank you.
>
> ---
>
> [1] https://wiki.php.net/rfc/return_types
> [2] https://github.com/php/php-src/pull/1050
>

--089e0122ae36abe34c050e4f5cbe--