Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81758
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <008a01d03f06$8cae6f20$a60b4d60$@tekwire.net>
References: <CABBJUpdzJZFYwBh0trYMTFSBCDrjH66nJFrBRNhCQTGrpTRDgQ@mail.gmail.com>
 <CABBJUpdHA=ZMstdqMULVcjGC27dR6nt2J_KDr9r=HjmtE14CGA@mail.gmail.com> <008a01d03f06$8cae6f20$a60b4d60$@tekwire.net>
Date: Wed, 4 Feb 2015 12:05:18 +0800
Message-ID: <CABBJUpcX+q8u2uRyDk-gLAJDMkxtFvBT9yVWswX-X1--kSsrZA@mail.gmail.com>
To: francois <francois@tekwire.net>
Cc: PHP Internals <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [DICUSS]Cleanup resource handling APIs
From: laruence@php.net (Xinchen Hui)

Hey:

On Tue, Feb 3, 2015 at 12:37 AM, Fran=C3=A7ois Laupretre
<francois@tekwire.net> wrote:
>> De : Xinchen Hui [mailto:laruence@php.net]
>> furthermore, I'd like to discuss remove the handle in zend_resource stru=
ct..
>>
>> it may breaks some usage (use resource as long/double/string)
>>
>>    case IS_RESOURCE: {
>>             char buf[sizeof("Resource id #") + MAX_LENGTH_OF_LONG];
>>             int len;
>>
>>             len =3D snprintf(buf, sizeof(buf), "Resource id #"
>> ZEND_LONG_FMT, (zend_long)Z_RES_HANDLE_P(op));
>>             return zend_string_init(buf, len, 0);
>>         }
>
> I don't understand how you can delete the resource if you remove the hand=
le from the zend_resource struct. Or would you store the index elsewhere ?

if you use HashTable ,  yes, it's hard to get rid of it, but we can
hidden it from user land..

and actually,  we only use integer index of regular_list for zend_resource.=
.

if we decide to remove handle, then it maybe easy to re-implement it
as a plain c array like zend_resource[];

and when doing realloce, we allocate new segment, and link them togther. et=
c

thanks
>
> Regards
>
> Fran=C3=A7ois
>



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/