Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81682
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <00ac01d03f0e$09a0ce90$1ce26bb0$@tekwire.net>
References: <008b01d03f06$bc8e9940$35abcbc0$@tekwire.net>
	<54CFAAA5.6050700@lerdorf.com>
	<00ac01d03f0e$09a0ce90$1ce26bb0$@tekwire.net>
Date: Tue, 3 Feb 2015 13:40:17 +0700
Message-ID: <CAEZPtU69bWgekkNHaqxkinzq5+zE-rvypEhhZ9dBTcGd47MgeQ@mail.gmail.com>
To: =?UTF-8?Q?Fran=C3=A7ois_Laupretre?= <francois@tekwire.net>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bea30cc1aca8d050e295804
Subject: RE: [PHP-DEV] [VOTE] Add is_cacheable() stream-wrapper operation
From: pierre.php@gmail.com (Pierre Joye)

--047d7bea30cc1aca8d050e295804
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Feb 3, 2015 12:31 AM, "Fran=C3=A7ois Laupretre" <francois@tekwire.net> w=
rote:
>
> > De : Rasmus Lerdorf [mailto:rasmus@lerdorf.com]
> > Doesn't this imply that "path" is the one true cache key? There are som=
e
> > issues with that which we will have to address at some point. For
> > example, when running fpm chrooted you need more than the path. We'll
> > likely need a more APC-like option here to use the device+inode for the
> > key. It seems like a generic mechanism like you are proposing needs to
> > take this into account and provide some mechanism that tells the opcode
> > cache how to determine uniqueness. Perhaps that is simply encoded into
> > the path parameter, but then maybe it should have a more appropriate
> > name.
>
> Yes, it implies that the path is the cache key. It implies that the strea=
m
> wrapper has a way to build unique and reproducible paths (PHK, for
instance,
> builds a unique ID from (dev/inode/mtime) when opening a package and
builds
> its paths from this ID).
>
> My first idea was to add a 'cache_key' element in the stream_stat()
result.
> This element would be a binary string to use as key. This way, the stream
> wrapper can return a path, a dev/inode/mtime concatenation, etc. If we
don't
> want to modify the stat() result, we can define a 'cache_key' hook in
> php_stream_wrapper_ops.

I am not a big fan of putting this info on the path. A path must remain a
path or URI, not some random generated string, requiring to be parsed to
get the actual path.

A cache key sounds cleaner, easier to implement and valid.

--047d7bea30cc1aca8d050e295804--