Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81655
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20150202210349.6FB91261948@dd15934.kasserver.com>
References: <20150202210349.6FB91261948@dd15934.kasserver.com>
Date: Mon, 2 Feb 2015 23:18:12 +0200
Message-ID: <CAPhkiZw42j6Jft1g72t5isAEBv_YbWzkKHYrM0ah6n=5pF_-Ew@mail.gmail.com>
To: Thomas Bley <mails@thomasbley.de>
Cc: Dmitry Stogov <dmitry@zend.com>, Andrea Faulds <ajf@ajf.me>, Nikita Popov <nikita.ppv@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] What do we need strict scalar type hints for?
From: narf@devilix.net (Andrey Andreev)

Hi,

On Mon, Feb 2, 2015 at 11:03 PM, Thomas Bley <mails@thomasbley.de> wrote:
> Here is a typical billing example which uses exceptions:
>
> <?php
> ini_set('error_reporting', E_ALL);
> ini_set('display_errors', 1);
>
> addVat('apples');
>
> function addVat($amount) {
>   if (!is_int($amount) && !is_float($amount)) {
>     throw new InvalidArgumentException('Argument 1 passed to '.__FUNCTION__.' must be of the type int|float, '.gettype($amount).' given');
>   }
>   return round($amount*1.19, 2);
> }
>
> Instead of multiple strict scalar hints (e.g. function addVat(int|float $amount){...}), I would prefer to have "numeric" as strict type:
> function addVat(numeric $amount){...}
>

That is an example where a weak hint to float would be better.

Here's a more appropriate example that I gave in the other thread:
http://marc.info/?l=php-internals&m=142142272705938&w=2

Cheers,
Andrey.