Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81607
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.215.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <6C58B302-C78A-490B-A333-4D1A71334E19@ajf.me>
References: <8DCD1B72-C81D-499E-B455-E4A042CD76E6@ajf.me>
	<B0C5801F-7D46-4CB0-9B2E-AF18C44DAF14@ajf.me>
	<CA+9eiLtPVoDYT71fYrZfxPk6a_m7ErFd2w8UBvu9ZeTEbnm4kA@mail.gmail.com>
	<alpine.DEB.2.11.1502021635000.16838@whisky.home.derickrethans.nl>
	<6C58B302-C78A-490B-A333-4D1A71334E19@ajf.me>
Date: Mon, 2 Feb 2015 18:48:25 +0200
Message-ID: <CAPhkiZwUBs5xwb5KfcVinoLDh7C2qOPD76bJAxVOnzN1hx_9WQ@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: Derick Rethans <derick@php.net>, Dmitry Stogov <dmitry@zend.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2
From: narf@devilix.net (Andrey Andreev)

Hi,

On Mon, Feb 2, 2015 at 6:39 PM, Andrea Faulds <ajf@ajf.me> wrote:
> Hey Derick,
>
>> On 2 Feb 2015, at 16:35, Derick Rethans <derick@php.net> wrote:
>>
>> On Mon, 2 Feb 2015, Dmitry Stogov wrote:
>>
>>> As I already told, in my opinion, version 0.1 was the perfect solution =
that
>>> fit into PHP semantic very well.
>>>
>>> declare(strict_types=3D1); - is really weird solution.
>>> It changes type hinting behavior per file scope, so, just to try strict
>>> type hinting in a big project, people will have to change every single =
PHP
>>> file.
>>
>> THis is why I believe it makes more sense to have this switch on the
>> callee side, instead of on the calling side.
>
> That does have its advantages. But it also has some quite severe problems=
.
>
> For starters, if you set that flag on the callee side, you just broke eve=
rything that uses that function and passes the =E2=80=9Cwrong=E2=80=9D type=
. That=E2=80=99s a migration headache.
>
> It also means that you don=E2=80=99t have any choice over strictness as t=
he user of an API: some APIs are strict, others weak. That means three line=
s of code might use three different approaches argument strictness. I don=
=E2=80=99t like that terribly much.
>

As already said, we're just going around in circles at this point, but
a migration issue?

Whatever code using the scalar type hints should be *new* code in
userland. You're basing your whole argument on the assumption that all
internal functions would break with strict=3D1 ... nobody needs that and
it doesn't have to be done.

Cheers,
Andrey.