Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81566
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.47 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CABBJUpe-Fj687crHyniinfE4NPuuJBrShqKAivEK_oXHKD3p-g@mail.gmail.com>
References: <54CC625E.8030802@lerdorf.com> <CALJZF3gcNP_9Xq-hO74GD2N89E8fSf32asn2D6z5BVgH2UzCwA@mail.gmail.com>
 <54CC8115.20705@lerdorf.com> <CABBJUpe-Fj687crHyniinfE4NPuuJBrShqKAivEK_oXHKD3p-g@mail.gmail.com>
Date: Mon, 2 Feb 2015 17:52:59 +0900
Message-ID: <CAGa2bXZfC6-H=Leo8f8gPNgL_osvgh4Ztu=dqCzFC2isstBXFQ@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>, Michael Wallner <mike@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1133c9622a7513050e1717a1
Subject: Re: [PHP-DEV] Magic getter bug tickled by Moodle
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a1133c9622a7513050e1717a1
Content-Type: text/plain; charset=UTF-8

Hi Xinchen,

On Sat, Jan 31, 2015 at 7:15 PM, Xinchen Hui <laruence@php.net> wrote:

> must be fixed,
>
> https://github.com/php/php-src/commit/1a60175e2595a24ebc3b6d80a112d574c6c98f58
>

Impressive work!

It's irrelevant probably. I only get one valgrind leak with TS build now.
NTS is fine.

[yohgaki@dev php-src]$ USE_ZEND_ALLOC=0 valgrind --track-origins=yes
--leak-check=full ./sapi/cli/php -r "echo 1;"
==13614== Memcheck, a memory error detector
==13614== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==13614== Using Valgrind-3.10.1 and LibVEX; rerun with -h for copyright info
==13614== Command: ./php-bin -r echo\ 1;
==13614==
1==13614==
==13614== HEAP SUMMARY:
==13614==     in use at exit: 88,808 bytes in 2,768 blocks
==13614==   total heap usage: 32,420 allocs, 29,652 frees, 3,656,230 bytes
allocated
==13614==
==13614== 376 bytes in 1 blocks are definitely lost in loss record 89 of 135
==13614==    at 0x4C29BCF: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==13614==    by 0xAEB3B5: alloc_globals_ctor (zend_alloc.c:2382)
==13614==    by 0xA6665C: ts_allocate_id (TSRM.c:259)
==13614==    by 0xAEB4B9: start_memory_manager (zend_alloc.c:2405)
==13614==    by 0xB21D09: zend_startup (zend.c:572)
==13614==    by 0xA6DA0F: php_module_startup (main.c:2105)
==13614==    by 0xBD2FB1: php_cli_startup (php_cli.c:421)
==13614==    by 0xBD53B7: main (php_cli.c:1341)
==13614==
==13614== LEAK SUMMARY:
==13614==    definitely lost: 376 bytes in 1 blocks
==13614==    indirectly lost: 0 bytes in 0 blocks
==13614==      possibly lost: 0 bytes in 0 blocks
==13614==    still reachable: 88,432 bytes in 2,767 blocks
==13614==         suppressed: 0 bytes in 0 blocks
==13614== Reachable blocks (those to which a pointer was found) are not
shown.
==13614== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==13614==
==13614== For counts of detected and suppressed errors, rerun with: -v
==13614== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)


--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a1133c9622a7513050e1717a1--