Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81498
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.169 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPwsocHwEZ-31_xV6rfCavphJ65+GtJVJbe3Zi9=R0us149Onw@mail.gmail.com>
References: <CAOXH8SV6ecvTF3z-yA7pUDW+8-18bZqjCviumqQqR9Yqnh5KKA@mail.gmail.com>
 <CAGa2bXZx1mLyP342h6HqP628hcXsRnEKNnp8QjCeWB-ygyN2NQ@mail.gmail.com>
 <CAOXH8SVReE5u80H8E5j9WpW9tCqjw7YxCqbjtUjgdi3k5WuSug@mail.gmail.com>
 <46440117-42C7-40DD-8504-4EE938385050@tobin.nl> <CAPwsocHwEZ-31_xV6rfCavphJ65+GtJVJbe3Zi9=R0us149Onw@mail.gmail.com>
Date: Sun, 1 Feb 2015 04:59:40 +0900
Message-ID: <CAGa2bXa-=K0EoVXNaaFtSXyTEWLaN949iaRrSpetvvBQi9OrxA@mail.gmail.com>
To: Leigh <leight@gmail.com>
Cc: Bas van Beek <bas@tobin.nl>, Markus Amalthea Magnuson <markus.magnuson@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>, sas@php.net
Content-Type: multipart/alternative; boundary=001a11c1257ec67ef5050df82bf5
Subject: Re: [PHP-DEV] Why does session.gc_maxlifetime default to 1440 seconds?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c1257ec67ef5050df82bf5
Content-Type: text/plain; charset=UTF-8

Hi Leigh,

On Sat, Jan 31, 2015 at 8:24 PM, Leigh <leight@gmail.com> wrote:

> On 31 January 2015 at 11:12, Bas van Beek <bas@tobin.nl> wrote:
> >
> > Well the number 1440 itself is not so arbitrary as it's the amount of
> minutes in a day. Maybe that's why the number popped up.
> >
> > In the end 24 minutes does seem to be fine for the majority of people
> and with people that care about session duration it's really easy to update
> :)
> >
>
> I like the idea of this being a 15+ year old "bug" where minutes were
> used instead of seconds :)


session.cache_expire? It's minutes. Do you mean session.cache_expire should
be seconds?

session.gc_maxlifetime is second.
files/mm take it as seconds.

mod_files.c - master
    295                 /* check whether its last access was more than
maxlifet ago */
    296                 if (VCWD_STAT(buf, &sbuf) == 0 &&
    297                         (now - sbuf.st_mtime) > maxlifetime) {
    298                     VCWD_UNLINK(buf);
    299                     nrdels++;

mod_mm.c - master
    458     limit -= maxlifetime;
    459
    460     mm_lock(data->mm, MM_LOCK_RW);
    461
    462     ehash = data->hash + data->hash_max + 1;
    463     for (ohash = data->hash; ohash < ehash; ohash++) {
    464         for (sd = *ohash; sd; sd = next) {
    465             next = sd->next;
    466             if (sd->ctime < limit) {
    467                 ps_mm_debug(("purging %s\n", sd->key));
    468                 ps_sd_destroy(data, sd);
    469                 (*nrdels)++;
    470             }
    471         }
    472     }

Current session module does not keeping last update time and relayed on
probability based GC solely. gc_maxlifetime value does not have precise
meaning.

I proposed precise session data deletion in other thread. The same can be
done for precise session data expiration.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c1257ec67ef5050df82bf5--