Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81492
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54CC8E81.3020104@beccati.com>
References: <CABDNdAHHSVK86KmOoXZLX-iqgmGMNiLAT8-1iouirHWxWkihJg@mail.gmail.com>
	<54CC8E81.3020104@beccati.com>
Date: Sat, 31 Jan 2015 12:31:48 -0500
Message-ID: <CABDNdAHR-KShYcHNbzCB3d7dAgyxSi3g_j88y1NLdXyHDkGawg@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] ReflectionParameter::getClassName()
From: pjsturgeon@gmail.com (Philip Sturgeon)

On Sat, Jan 31, 2015 at 3:12 AM, Matteo Beccati <php@beccati.com> wrote:
> Hi Phil,
>
>
> On 31/01/2015 05:14, Philip Sturgeon wrote:
>>
>> This RFC adds a new method to ReflectionParameter to allow easy access
>> to a class name in a type hint, avoiding the need to actually load the
>> class and use `get_class()` or `::class`.
>>
>> https://wiki.php.net/rfc/reflectionparameter-getclassname
>
>
> Looks good to me!
>
> Just a couple of minor things.
>
> 1) The RFC does not mention what happens if the parameter is not type
> hinted, or what happens when hints are namespaced and/or use clauses are
> used.
>
> 2) There's a tiny bit of overlap with "scalar type hints", if it is accepted
> (in any form) and reflection support added to it. Depending on the way such
> reflection support is implemented, the method proposed here could be a
> perfect match. Or perhaps it could be in the way.
>
>
> Cheers
> --
> Matteo Beccati
>
> Development & Consulting - http://www.beccati.com/

Thanks! Good questions.

1) Thanks for your help on GitHub in making tests for this. Implemented nicely.

2) There might be some overlap in the scalar type hint stuff kinda,
but I'd like to think there isn't. getClassName() is just
getClass()->name without loading the actual class. Getting "string' or
"int" back is likely to have its own logic in the scalar type hint RFC
so I'd rather stay clear of it altogether.