Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81472
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.216.180 as permitted sender)
Message-ID: <54CC8FC2.10704@lerdorf.com>
Date: Sat, 31 Jan 2015 00:18:10 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Dmitry Stogov <dmitry@zend.com>, 
 PHP Internals <internals@lists.php.net>
CC: Nikita Popov <nikita.ppv@gmail.com>
References: <CA+9eiLsqy8NWA6dp733NN5O+dDwHxDPV2DBK-jHxp90BA6uKZQ@mail.gmail.com> <CA+9eiLt3ULetzKRkFb_e-=D53Yv+s6wnOdSMwT-rjdoyScGViQ@mail.gmail.com>
In-Reply-To: <CA+9eiLt3ULetzKRkFb_e-=D53Yv+s6wnOdSMwT-rjdoyScGViQ@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="tb0Gx3biMGKJcMvMHow5ERoixDgjL5umI"
Subject: Re: [PHP-DEV] [RFC] Fix "foreach" behavior
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--tb0Gx3biMGKJcMvMHow5ERoixDgjL5umI
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/30/2015 09:10 PM, Dmitry Stogov wrote:
> Hi,
>=20
> Nikita got an idea about stopping changing of array/object internal
> pointers even in forech by reference.
> I've added an additional RFC section:
>=20
> https://wiki.php.net/rfc/php7_foreach#additional_behavoir_change
>=20
> Trivial implementation on top of the main patch:
>=20
> https://gist.github.com/dstogov/63b269207ba0aed8b776
>=20
> and an additional proposed voting question.
>=20
> Also, the implementation now must be almost complete.

I built your branch and applied Nikita's patch as well and ran it
through my benchmark box here. Before -> After numbers in requests/sec:

Drupal8-b4        182 ->  184
Wordpress-4.1     661 ->  675
phpbb-3.1.2      1071 -> 1084
Mediawiki-1.24.1  304 ->  306
Opencart-2.0.1.1  458 ->  459
WardrobeCMS-1.2.0 993 ->  999
Geeklog-2.1.0     823 ->  825
Traq-3.5.2       1869 -> 1902

So about a 1% boost across the board except for Opencart, but it spends
most of its time creating sessions on disk and writing to MySQL.

No obvious visible things broke in any of these. Overall, even without
the performance boost, I think making the edge-case foreach behaviour
consistent and predictable is a good thing on its own.

-Rasmus


--tb0Gx3biMGKJcMvMHow5ERoixDgjL5umI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlTMj8IACgkQlxayKTuqOuAf0QCeP++g/ako2rkieHPOhnL12KuJ
0WQAnjzHaAIVQvjzcECTZiaNLS9Dmv+3
=RDrs
-----END PGP SIGNATURE-----

--tb0Gx3biMGKJcMvMHow5ERoixDgjL5umI--