Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81468 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81321 invoked from network); 31 Jan 2015 05:10:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Jan 2015 05:10:53 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.182 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 209.85.220.182 mail-vc0-f182.google.com Received: from [209.85.220.182] ([209.85.220.182:34957] helo=mail-vc0-f182.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 53/FD-34022-CD36CC45 for ; Sat, 31 Jan 2015 00:10:52 -0500 Received: by mail-vc0-f182.google.com with SMTP id kv19so12055973vcb.13 for ; Fri, 30 Jan 2015 21:10:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Va80pJ7PMATy8u5TiIF0cNYAn4e4ybEA8FwTR5fsLOo=; b=jwzOLVEk7mBwLRno3d5qyjROLqcR/UQ29X54pBn4J859FeCx9bLMhqzVXjqxoSPafU wrn6w6OFeMQcQslpCbVrKpzKGPVNvCTbXWqVsK0MoaVQ54fzekbk0DzuiTh9rqv/fu6t V8x2Yjjgn0TRq0kWDOWvtzOk0mJFB3dgqqRSf7Es0FskHlUOiqODzz8r4eNmcXgaa3FI qJFT9Vlk2yEnDZ21A93vmfm0fDMGffgwFE3PareC1xcI4Sv8N8LCJG6BTvHuIBzWUTkQ vuOkXWEBaxyl+jHXZOfhrN4TczdHdW8sOaY+yeAzRu4lRILyq0SeOx11ictWJemy1JBi zlQw== X-Gm-Message-State: ALoCoQkj68DDOCpHf8QheYBWf5Jp55/M1WTsz98oQj9rAiQWgbdNwd4cwfJMnRHd1ynUyGISyH3HGi8k7p3KRDeiuo7ioCPpB806VHCHLKdtSxYRh/TurD1nyYzUHYEdXzYBb1KxN5biH9lxB5HoqX4Z02mQ/NOR9Q== MIME-Version: 1.0 X-Received: by 10.221.21.131 with SMTP id qs3mr5197177vcb.33.1422681050197; Fri, 30 Jan 2015 21:10:50 -0800 (PST) Received: by 10.52.26.40 with HTTP; Fri, 30 Jan 2015 21:10:50 -0800 (PST) In-Reply-To: References: Date: Sat, 31 Jan 2015 09:10:50 +0400 Message-ID: To: PHP Internals Cc: Nikita Popov Content-Type: multipart/alternative; boundary=001a11339f8aa04874050debbede Subject: Re: [PHP-DEV] [RFC] Fix "foreach" behavior From: dmitry@zend.com (Dmitry Stogov) --001a11339f8aa04874050debbede Content-Type: text/plain; charset=UTF-8 Hi, Nikita got an idea about stopping changing of array/object internal pointers even in forech by reference. I've added an additional RFC section: https://wiki.php.net/rfc/php7_foreach#additional_behavoir_change Trivial implementation on top of the main patch: https://gist.github.com/dstogov/63b269207ba0aed8b776 and an additional proposed voting question. Also, the implementation now must be almost complete. Thanks. Dmitry. On Fri, Jan 30, 2015 at 10:23 AM, Dmitry Stogov wrote: > Hi, > > I'd like to start discussion about fixing inconsistent "foreach" statement > behavior. > The implementation is almost done. It not only fixes inconsistencies in a > defined by RFC way but also improves performance in most usual cases, > because now foreach by value over array doesn't require array duplication. > > https://wiki.php.net/rfc/php7_foreach > > https://github.com/php/php-src/pull/1034 > > I'm going to continue work on implementation improvement and may be fixing > related behavior of some internal functions when they used on array > iterated by foreach by reference (e.g. array_unshift()). However, the > conceptual behavior defined in RFC is not going to be changed anymore. > > Thanks. Dmitry. > > --001a11339f8aa04874050debbede--