Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81365
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.54 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXZVhKocjfNLsu4dwce0zDQqa2A8ABBshu+DyCS9e1q2_g@mail.gmail.com>
References: <CAGa2bXb-iYj3sLnnBZmu5Yag-6E7CD+goKq5ENUsBcoiGo2cUA@mail.gmail.com>
 <54C9ECB1.7000901@fedoraproject.org> <CAGa2bXZVhKocjfNLsu4dwce0zDQqa2A8ABBshu+DyCS9e1q2_g@mail.gmail.com>
Date: Thu, 29 Jan 2015 18:30:24 +0900
Message-ID: <CAGa2bXY8gTWLouP8SNvbrWAhmmWu7cnBfCgnv5=9Xi7hekOsCg@mail.gmail.com>
To: Remi Collet <remi@fedoraproject.org>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113a2aa2a744aa050dc72573
Subject: Re: [PHP-DEV] Session: PS(mod)->create() or PS(mod)->read() parameter?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a113a2aa2a744aa050dc72573
Content-Type: text/plain; charset=UTF-8

Hi all,

On Thu, Jan 29, 2015 at 5:24 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> A new API seems really cleaner.
>
>
> Reasonable discussion. I'll prepare API version patch later.


This is the patch. It's not complete as user save handler requires more
work.
Simply read() is called as create() now. It's a PoC patch.

https://github.com/yohgaki/php-src/compare/master-session-new-api2

It's not too complex compared to parameter version.

https://github.com/yohgaki/php-src/compare/master-session-new-api

The issue with create() is that it enforces save handlers to implement
create(). It may be implemented that to check null handler to allow
save handler w/o create(), but it wouldn't look nice.

Since all save handlers must be rewritten for PHP7, it would be the
best to have only one save handler definition for internal save handlers
while keeping user save handler compatibility. Dirty part can be hidden
in mod_user.c.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a113a2aa2a744aa050dc72573--