Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81354
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.46 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Date: Thu, 29 Jan 2015 16:00:44 +0900
Message-ID: <CAGa2bXb-iYj3sLnnBZmu5Yag-6E7CD+goKq5ENUsBcoiGo2cUA@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c1257e6575a6050dc50e9d
Subject: Session: PS(mod)->create() or PS(mod)->read() parameter?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c1257e6575a6050dc50e9d
Content-Type: text/plain; charset=UTF-8

Hi all, session save handler developer especially,

I would like to improve session save handler module API for PHP7.
When new session data is created, some save handlers need to create
new session data explicitly. e.g. RDBMS based save handler.

New session module validates session data existence via
PS(mod)->validate_sid().
When new data record is needed, RDBMS needs INSERT query to create a record.
Since record existence is checked by validate_sid(), SELECT query in
PS(mod)->read()
that checks record existence is not required if there is proper API.
Note: validate_sid() is there to enforce secure save handler implementation.

One option is to have PS(mod)->create() for new session.
The other is additional new_id flag parameter for PS(mod)->read().

Both change requires API change, but it wouldn't be issue for PHP7.

Have new create API or new parameter for PS(mod)->read()? I don't care
which.
If there is no comment, I'll add new parameter since it's simpler.

Comments are appreciated.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c1257e6575a6050dc50e9d--