Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81304
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.214 cause and error)
Message-ID: <54C8CF30.6030803@lsces.co.uk>
Date: Wed, 28 Jan 2015 11:59:44 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CA+kxMuSmCsq5cPZ2ZBExFKdVVW5+uOkwTSuiGLhnnHDjFyRNOg@mail.gmail.com> <n4mgca9p45d32v05i12pf0ja6jc43e2bdp@4ax.com> <54C8A5D2.3060108@lsces.co.uk> <ddbhca9usm1uvfe3pfn11urd34fijdmapo@4ax.com>
In-Reply-To: <ddbhca9usm1uvfe3pfn11urd34fijdmapo@4ax.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: imagick on PHP 7 was Stepping stones to a working
 php7 ...
From: lester@lsces.co.uk (Lester Caine)

On 28/01/15 09:57, Jan Ehrhardt wrote:
> Lester Caine in php.internals (Wed, 28 Jan 2015 09:03:14 +0000):
>> >On 28/01/15 03:45, Jan Ehrhardt wrote:
>>> >> After these commits php_imagick.dll compiled with VC11 and (for Lester)
>>> >> showed itself in phpinfo:
>>> >> https://phpdev.toolsforresearch.com/php-7.0.0-dev-nts-Win32-VC11-x86.htm
>> >
>> >Progress ...
>> >But mine is not listing the supported formats :(
>> >http://php7.lsces.org.uk/phpinfo.php
> This happens when the extension cannot find the installed IM-filters,
> AFAIK. Strangely enough I saw the same happen with the x64 VC11 build
> for PHP7 (phpseven branch). But the x64 VC11 builds do show the
> supported formats (master branch).
> 
>> >http://hg.lsces.org.uk/hg/imagick/rev/7aec3f35fc99 is the patch I
>> >applied Dan
> Hmm, your patch reminds me of
> https://github.com/Jan-E/imagick/commits/phpseven ;-)
> 
> The patches for the deprecated functions are already present in the
> imagick-master, but not in the phpseven branch. Maybe there are more
> differences between master and phpseven that explain the difference in
> supported formats between PHP 5.6 and PHP7.

This is perhaps an example of where the basic structure of PHP code is a
problem. I have the code used for the current production extension which
is I think from a period when it was still part of php-src. Trying to
compare that with the current builds across multiple forks is just
messy. Just which fork should I use  ...

I've got the same problem with interbase/firebird for a slightly
different reason ... it's development history is buried in php-src.

In the good old days of CVS one simply created a 'view' of a modular
repository selecting the modules you wanted ... freezing or forking a
module for a new composite build. This is something neither git or hg
considered had any place in DVCS when they were first developed, and
while 'sub-repo' is begrudgingly supported in both these days it is not
considered 'the proper way to work'. For projects like PHP I consider it
essential in order to avoid the sort of hacking such as
https://github.com/m6w6/php-src/tree/merge-http

PEAR also fits into a proper model where all of the elements we can use
for a distributed build ARE available as elements, and a distribution
either creates a series of shared packages or a single static build bu
from the whole code base rather than some cherry picked subset + the
elements that are no longer considered by some developers ...

Just where do I go for an 'unloved' extension or add-on ...

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk